Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eslint-plugin): [no-unnecessary-condition] fix false positive with computed member access and branded key type#7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromyf-yang:issue7700
Nov 17, 2023

Conversation

yf-yang
Copy link
Contributor

PR Checklist

Overview

TypeScript'sgetIndexInfoOfType only accepts purestring ornumber type, so instead we extract all the index infos and compare their keyType by getting the type name of the key type.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@yf-yang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

stianjensen reacted with heart emoji

@netlify
Copy link

netlifybot commentedSep 30, 2023
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3b6693d
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6557239fef541a000788bd2c
😎 Deploy Previewhttps://deploy-preview-7706--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 89 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedSep 30, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitae66a81. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, thanks! Just requesting a bit more tests. 🚀

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelOct 19, 2023
@JoshuaKGoldberg
Copy link
Member

Btw, the Netlify failures are unrelated to this PR. You should be able to ignore them.

@yf-yang
Copy link
ContributorAuthor

yf-yang commentedOct 23, 2023
edited
Loading

Just curious 👀 , you are using squash and merge option, so only the PR title should follow conventional commit guidelines, the commit messages don't matter, right?

@Josh-Cena
Copy link
Member

so only the PR title should follow conventional commit guidelines, the commit messages don't matter, right?

That's right. You can do whatever you want with commit titles and commit as many times as you want.

@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelNov 17, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀 thanks!

@JoshuaKGoldbergJoshuaKGoldberg merged commitf151b26 intotypescript-eslint:mainNov 17, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 25, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [@typescript-eslint/no-unnecessary-condition] False positive when enable tsconfig noUncheckedIndexedAccess and branded string key
3 participants
@yf-yang@JoshuaKGoldberg@Josh-Cena

[8]ページ先頭

©2009-2025 Movatter.jp