Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [class-methods-use-this] detect a problematic case for private/protected members ifignoreClassesThatImplementAnInterface is set#7705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

tetsuharuohzeki
Copy link
Contributor

@tetsuharuohzekitetsuharuohzeki commentedSep 30, 2023•
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Thisfixes#7704.

TypeScript's interface feature does not have any private/protected member as a part of it.

So the ruleclass-methods-use-this enabling ignoreClassesThatImplementAnInterface=true should warn the case of that the implementation is not a part of interface.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@tetsuharuohzeki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedSep 30, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitbe7c886
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6557ebe495ba9600084d121a
😎 Deploy Previewhttps://deploy-preview-7705--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedSep 30, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3625d70. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

@tetsuharuohzekitetsuharuohzeki marked this pull request as ready for reviewSeptember 30, 2023 05:27
@tetsuharuohzekitetsuharuohzekiforce-pushed thefix-7704-class-methods-use-this branch from4d4e714 tod4b5aafCompareOctober 18, 2023 04:18
@JoshuaKGoldberg
Copy link
Member

Converting to draft since the linked issue hasn't been accepted yet. Let's continue conversation there.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as draftOctober 19, 2023 15:53
@tetsuharuohzekitetsuharuohzekiforce-pushed thefix-7704-class-methods-use-this branch 2 times, most recently from80b3efe to3625d70CompareOctober 24, 2023 21:26
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewNovember 17, 2023 18:06
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesNov 17, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK! This looks great to me - just one docs suggestion from me. What do you think@tetsuharuohzeki?

Thanks for waiting btw - I'm excited about this option!

Comment on lines 55 to 56
| 'public-fields'
/** Ignore classes that specifically implement some interface */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hmm, this looks a little off... outside the scope of this PR.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I tried to remove its comment but I seemnx run eslint-plugin:test generate it...

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I tried to add more descriptions but it cannot remove extra comments.
7390468

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah I think this is just something odd in the repository, separate from your changes. No worries. Thanks for trying though!

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelNov 17, 2023
@tetsuharuohzekitetsuharuohzekiforce-pushed thefix-7704-class-methods-use-this branch from3625d70 to7390468CompareNovember 17, 2023 20:40
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesNov 17, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Swell, thanks!

@JoshuaKGoldberg
Copy link
Member

I introduced a merge conflict onmain and can fix it :)

@tetsuharuohzekitetsuharuohzeki changed the titlefix(eslint-plugin): [class-methods-use-this] detect a problematic case for private/protected members ifignoreClassesThatImplementAnInterface istruefix(eslint-plugin): [class-methods-use-this] detect a problematic case for private/protected members ifignoreClassesThatImplementAnInterface is setNov 17, 2023
@tetsuharuohzekitetsuharuohzekiforce-pushed thefix-7704-class-methods-use-this branch from42e2148 tob7beb57CompareNovember 17, 2023 22:25
@tetsuharuohzeki
Copy link
ContributorAuthor

@JoshuaKGoldberg

Thank you for your review! I rebase my change sets on the latest main!

@JoshuaKGoldberg
Copy link
Member

Amazing, thanks! Saved me a bit of time wrestling with it locally. 🙂

@JoshuaKGoldbergJoshuaKGoldberg merged commit155aa1f intotypescript-eslint:mainNov 17, 2023
@tetsuharuohzekitetsuharuohzeki deleted the fix-7704-class-methods-use-this branchNovember 17, 2023 23:02
@tetsuharuohzeki
Copy link
ContributorAuthor

@JoshuaKGoldberg Thank you for accepting my patch.

JoshuaKGoldberg reacted with heart emoji

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 25, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [class-methods-use-this] Cannot detect a problematic case for private/protected members ifignoreClassesThatImplementAnInterface option istrue
2 participants
@tetsuharuohzeki@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp