Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(utils): type portability withRuleCreator, fix #7605#7690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@antfu
Copy link
Contributor

@antfuantfu commentedSep 23, 2023•
edited
Loading

PR Checklist

Overview

Reproduction:https://github.com/antfu/repro-ts-eslint-utils-dts - fails on both tsup and unbuild

Reproduction with patch:https://github.com/antfu/repro-ts-eslint-utils-dts/tree/patched (thepatched branch) - both tsup and unbuild work correctly and generated the following dts:

import{ESLintUtils}from'@typescript-eslint/utils';declareconst_default:ESLintUtils.RuleModule<"missingIfNewline",[],ESLintUtils.RuleListener>;export{_defaultasdefault};

condorheroblog, nakrovati, niexia, cwandev, and Rel1cx reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@antfu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedSep 23, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit318b0a5
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/650e9a8b4ff08e0008760a9a
😎 Deploy Previewhttps://deploy-preview-7690--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedSep 23, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit318b0a5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 3 targets

Sent with 💌 fromNxCloud.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Swell, thanks! ✨

@JoshuaKGoldbergJoshuaKGoldberg merged commit4e23591 intotypescript-eslint:mainSep 23, 2023
@antfuantfu deleted the fix/utils-types-portable branchSeptember 23, 2023 14:56
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 1, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: Explain how to get around "not portable" TypeScript type errors

2 participants

@antfu@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp