Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [prefer-readonly] private fields support#7686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 9 commits intotypescript-eslint:mainfromJamesernator:prefer-readonly-private-fields
Oct 19, 2023
Merged

feat(eslint-plugin): [prefer-readonly] private fields support#7686

JoshuaKGoldberg merged 9 commits intotypescript-eslint:mainfromJamesernator:prefer-readonly-private-fields
Oct 19, 2023

Conversation

Jamesernator
Copy link
Contributor

PR Checklist

Overview

This adds private field support toprefer-readonly with the same behaviour as for classic TS private properties.

The tests are just duplicates of the existing tests, but withprivate name replaced with#name.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Jamesernator!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedSep 21, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit7dd8f6b
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/653162b8c5dee4000810fee2
😎 Deploy Previewhttps://deploy-preview-7686--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 95 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JamesernatorJamesernator changed the title[prefer-readonly] private fields support[feat] prefer-readonly - private fields supportSep 21, 2023
@nx-cloud
Copy link

nx-cloudbot commentedSep 21, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit7dd8f6b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

@JamesernatorJamesernator changed the title[feat] prefer-readonly - private fields supportfeat: prefer-readonly - private fields supportSep 21, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

+5/-1 in implementation
+907 in tests

Love it 😂. Super thorough tests - nicely done! 👏

Just requesting changes on a bit of docs too please. Thanks!

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelSep 21, 2023
@JoshuaKGoldberg
Copy link
Member

👋 Hey@Jamesernator! Just checking in, is this still something you have time for? No worries if not - I just don't want to leave it hanging.

@JoshuaKGoldbergJoshuaKGoldberg added the stalePRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period labelOct 18, 2023
@Jamesernator
Copy link
ContributorAuthor

👋 Hey@Jamesernator! Just checking in, is this still something you have time for? No worries if not - I just don't want to leave it hanging.

I've added a small docs change to mention it now affects both typescriptprivate modifiers and private fields.

@JoshuaKGoldberg
Copy link
Member

Great thanks! If youre-request review through the GitHub UI we'll be notified to take a look. Otherwise we don't always go back to PRs.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesOct 19, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome, thanks! The tests are just as awesomely thorough as before. 🚀

@JoshuaKGoldbergJoshuaKGoldberg removed awaiting responseIssues waiting for a reply from the OP or another party stalePRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period labelsOct 19, 2023
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat: prefer-readonly - private fields supportfeat(eslint-plugin): [prefer-readonly] private fields supportOct 19, 2023
@JoshuaKGoldbergJoshuaKGoldberg merged commit0e875bf intotypescript-eslint:mainOct 19, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: [prefer-readonly] check #private class fields
2 participants
@Jamesernator@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp