typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(eslint-plugin): [no-confusing-void-expression] handle unfixable cases#7674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromyeonjuan:fix/6187

Oct 16, 2023

Merged

fix(eslint-plugin): [no-confusing-void-expression] handle unfixable cases#7674

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromyeonjuan:fix/6187

Oct 16, 2023

Conversation

Copy link

Contributor

yeonjuan commentedSep 19, 2023

PR Checklist

Addresses an existing open issue:fixesBug: [no-confusing-void-expression] Wrong autofix fora ? void : T #6187
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This change will prevent autofixes in certain cases. Before the change, it worked like this

constf=function(){letnum=1;returnnum ?console.log('foo') :num;};// after fixconstf=function(){letnum=1;num ?console.log('foo') :num;};

I changed to not apply fix to node which can be conditionally void.

letnum=1;constfoo=()=>num ?console.log('foo') :num;constf=function(){letnum=1;returnnum ?console.log('foo') :num;};

Copy link

Contributor

typescript-eslintbot commentedSep 19, 2023

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 19, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`71f9ef4`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/652c029ef3b5380008d16691
😎 Deploy Preview	https://deploy-preview-7674--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 89 (🔴 down 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedSep 19, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit71f9ef4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

yeonjuan force-pushed thefix/6187 branch 2 times, most recently from22f78d9 toef650d0Compare

September 28, 2023 12:36

JoshuaKGoldberg requested changes

Oct 10, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great - nice spot on checkingts.TypeFlags.VoidLike! This function works perfectly but just has a bit of dead code I think. Requesting changes just on that.

Super thorough tests, too! 👏