Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): [playground] improve mobile design#7672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 12 commits intomainfromchore/improve-mobile-playground
Nov 13, 2023

Conversation

armano2
Copy link
Collaborator

PR Checklist

Overview

Improve playground design on mobile devices

this change has been extracted from#6656

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedSep 19, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit37bf042
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65522074255767000821c8f9
😎 Deploy Previewhttps://deploy-preview-7672--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedSep 19, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4529592. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Screenshot_20230920-093623.png

The layout seems a bit wrong on mobile - the bottom panel is real small and I can't scroll to see the content.

@armano2
Copy link
CollaboratorAuthor

armano2 commentedSep 20, 2023•
edited
Loading

can you tell me what browser / os is that, i will check it out

edit, nvm i can see where issue is, after clearing cache i'm able to reproduce it on my phone and in browser

issue seem to be present only in normal build and not in dev mode

edit, issue fixed

@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelNov 10, 2023
Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this is looking good to me from a design perspective and the react code sure looks like react code (it's been a while since I've properly written any react so :nodders:

my only point of feedback is this logic here - chained, mixed logicals within a JSX expression are pretty gnarly to read, but we've already got#7630 for that so :nodders: again

@bradzacher
Copy link
Member

something about this PR is breaking in CI. The initial install step is failing to finish (it was auto-cancelled after SIX hours)

@bradzacherbradzacher added awaiting responseIssues waiting for a reply from the OP or another party and removed awaiting responseIssues waiting for a reply from the OP or another party labelsNov 11, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Swell, thanks!

@JoshuaKGoldbergJoshuaKGoldberg merged commit3e243f6 intomainNov 13, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the chore/improve-mobile-playground branchNovember 13, 2023 16:04
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 21, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@StyleShitStyleShitStyleShit requested changes

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergewebsite: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@armano2@bradzacher@JoshuaKGoldberg@StyleShit
[8]ページ先頭
©2009-2025 Movatter.jp