In#7535 I made a change to the script so that it used ourutils package to type anESLint call.
This actually introduced a nx cyclic dependency crash into the repo - but it looks like this crash was never seen due to caching or something I guess?

However on a fresh machine if you ranyarn, then it'll cause yarn to attempt to do a fresh build after an install and then nx would fail with

NX Could not execute command because the task graph has a circular dependency rule-schema-to-typescript-types:build --> type-utils:build --> utils:build --> scope-manager:build --> utils:build

cc@JamesHenry - this behaviour is super weird!

This PR moves the script to therepo-tools folder so that it's an isolated leaf, fixing the cyclic dependency.

chore: fix cyclic dependency in repo caused by generate-lib script ch…

58f5905

…anges

bradzacher added the repo maintenancethings to do with maintenance of the repo, and not with code/docs label

Sep 5, 2023

Copy link

Contributor

typescript-eslintbot commentedSep 5, 2023

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 5, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64f91a3b3e09390d067e94a7
😎 Deploy Preview	https://deploy-preview-7603--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (🔴 down 9 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

JoshuaKGoldberg previously approved these changes

Sep 5, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Heh, I just started gettin this too - thanks for the fix. I'll defer to@JamesHenry as the Nx wiz.

(assuming the lockfile is fixed ofc)

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Sep 5, 2023

Copy link

Member

JoshuaKGoldberg commentedSep 5, 2023

or actually,@bradzacher this feels like a good thing to get in asap - I'm happy to just get it in sooner

Copy link

MemberAuthor

bradzacher commentedSep 5, 2023

Yeah we can land it sooner then cycle back with James to investigate why this wasn't caught sooner by nx.

I'm not going to be able to get to my laptop for around 2 hours - if you wanted it asap feel free to pull and fix the lock file for me :)

Copy link

Member

JoshuaKGoldberg commentedSep 5, 2023

Well I'm stumped...

Internal Error: @typescript-eslint/typescript-eslint@workspace:.: This package doesn't seem to be present in your lockfile; run "yarn install" to update the lockfile    at V0.getCandidates (/Users/josh/.cache/node/corepack/yarn/3.6.3/yarn.js:435:5145)    at kf.getCandidates (/Users/josh/.cache/node/corepack/yarn/3.6.3/yarn.js:391:1264)    at /Users/josh/.cache/node/corepack/yarn/3.6.3/yarn.js:439:8033    at df (/Users/josh/.cache/node/corepack/yarn/3.6.3/yarn.js:390:11070)    at ge (/Users/josh/.cache/node/corepack/yarn/3.6.3/yarn.js:439:8013)    at async Promise.allSettled (index 0)    at async io (/Users/josh/.cache/node/corepack/yarn/3.6.3/yarn.js:390:10398)    at async /Users/josh/.cache/node/corepack/yarn/3.6.3/yarn.js:439:8545    at async ti.startProgressPromise (/Users/josh/.cache/node/corepack/yarn/3.6.3/yarn.js:390:47579)    at async je.resolveEverything (/Users/josh/.cache/node/corepack/yarn/3.6.3/yarn.js:439:6573)

Copy link

MemberAuthor

bradzacher commentedSep 5, 2023

Nuke a bitch and try again? That's my standard workflow for fixing yarn problems heh

Copy link

Member

JoshuaKGoldberg commentedSep 5, 2023

No juice :(

armano2 previously approved these changes

Sep 6, 2023

View reviewed changes

fix lock file

4bec329

bradzacher dismissed stale reviews fromarmano2 andJoshuaKGoldberg via4bec329

September 6, 2023 00:40

Copy link

nx-cloudbot commentedSep 6, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3e10dad. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
`nx build website`

✅ Successfully ran 39 targets

Sent with 💌 fromNxCloud.

fix yarn

a112e8f

Copy link

MemberAuthor

bradzacher commentedSep 6, 2023

okay so I now have a fresh and cleanyarn working.
I had to migrate our patches off ofpatch-package and ontoyarn patch (which is now built into yarn2).

bradzacher added3 commits

September 6, 2023 11:45

um?

ff89c19

lint

3dc8381

Update package.json

87f5e51

bradzacher commented

Sep 6, 2023

View reviewed changes

yarn.lock OutdatedShow resolvedHide resolved

bradzacher added2 commits

September 6, 2023 19:22

Update yarn.lock

299d9bc

updoot

3e10dad

Copy link

MemberAuthor

bradzacher commentedSep 7, 2023•
edited
Loading

GH statuses didn't update - but there was a netlify build flake.
Retried the deploy and it worked fine
https://app.netlify.com/sites/typescript-eslint/deploys/64f91a3b3e09390d067e94a7
(the netlify comment updated though...)