chore(ast-spec): exclude tsx fixtures from type-check#7602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intomainfromfix/exclude-tsx-files-from-typecheck

Sep 8, 2023

Merged

chore(ast-spec): exclude tsx fixtures from type-check#7602

bradzacher merged 1 commit intomainfromfix/exclude-tsx-files-from-typecheck

Sep 8, 2023

Conversation

Copy link

Collaborator

armano2 commentedSep 5, 2023

PR Checklist

Addresses an existing open issue:fixesRepo: v6 branch regression for adding to JSX.IntrinsicAttributes in typecheck task #7166
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

exclude tsx files from type-check
allow tests to be executed on windows

chore(ast-spec): exclude tsx files from type-check

08e0b7a

- allow tests to be executed on windows

armano2 requested a review fromJoshuaKGoldberg

September 5, 2023 02:14

Copy link

Contributor

typescript-eslintbot commentedSep 5, 2023

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 5, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`08e0b7a`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64f68f1c2428d90008d8d07d
😎 Deploy Preview	https://deploy-preview-7602--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

armano2 changed the title~~chore(ast-spec): exclude tsx files from type-check~~chore(ast-spec): exclude tsx fixtures from type-check

Sep 5, 2023

Copy link

nx-cloudbot commentedSep 5, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit08e0b7a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 40 targets