Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: add in the pull request file to not comment in closed prs#7592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 5 commits intotypescript-eslint:mainfromsfavello:patch-6
Sep 5, 2023

Conversation

sfavello
Copy link
Contributor

PR Checklist

Overview

Added a part in the pull requests page to not comment in PRs that has been closed and instead to file a new issue.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@sfavello!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedSep 2, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit0f2a6c0
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/64f78a1d4d49850008f4b7aa
😎 Deploy Previewhttps://deploy-preview-7592--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@sfavellosfavello marked this pull request as ready for reviewSeptember 2, 2023 17:28
@nx-cloud
Copy link

nx-cloudbot commentedSep 2, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0f2a6c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 40 targets

Sent with 💌 fromNxCloud.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesSep 2, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 thanks!

sfavello reacted with laugh emoji
@JoshuaKGoldberg
Copy link
Member

Oh - looks like a formatting issue in CI? I'm on mobile and can't check deeply at the moment.

sfavello reacted with eyes emoji

@sfavello
Copy link
ContributorAuthor

@JoshuaKGoldberg , Sorry about that. There was space after the period. Should be fixed. 👍🏼

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesSep 2, 2023
sfavelloand others added2 commitsSeptember 2, 2023 14:05
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Copy link
Member

@Josh-CenaJosh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

sfavello reacted with laugh emoji
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@codecov
Copy link

codecovbot commentedSep 5, 2023•
edited
Loading

Codecov Report

Merging#7592 (0f2a6c0) intomain (4899b95) willnot change coverage.
Report is 9 commits behind head on main.
The diff coverage isn/a.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #7592   +/-   ##=======================================  Coverage   87.23%   87.23%           =======================================  Files         387      387             Lines       13401    13401             Branches     3962     3962           =======================================  Hits        11690    11690             Misses       1327     1327             Partials      384      384
FlagCoverage Δ
unittest87.23% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🔥

@JoshuaKGoldbergJoshuaKGoldberg merged commit8175224 intotypescript-eslint:mainSep 5, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

@Josh-CenaJosh-CenaJosh-Cena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Ask not to post followup questions on merged PRs
3 participants
@sfavello@JoshuaKGoldberg@Josh-Cena
[8]ページ先頭
©2009-2025 Movatter.jp