typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

docs(eslint-plugin): replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes#7590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromgirishsontakke:issue-7582

Sep 21, 2023

Merged

docs(eslint-plugin): replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes#7590

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromgirishsontakke:issue-7582

Sep 21, 2023

Conversation

Copy link

Contributor

girishsontakke commentedSep 2, 2023

PR Checklist

Addresses an existing open issue:fixesDocs: Out-of-date TS error codes in eslint-recommended.ts #7582
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

this PR resolves the issue#7582.

TS error 2360 was not available in the list of errors athttps://github.com/microsoft/TypeScript/blob/v5.2.2/src/compiler/diagnosticMessages.json.
When trying to negating the left hand operand ofin operator in thistypescript playground I was getting TS error with code2322;

replaced the TS error 2360 with 2322

f983459

Copy link

Contributor

typescript-eslintbot commentedSep 2, 2023

Thanks for the PR,@girishsontakke!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedSep 2, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`dc0b203`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64f5e9ab1fc55700084141ae
😎 Deploy Preview	https://deploy-preview-7590--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedSep 2, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitdc0b203. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 40 targets

Sent with 💌 fromNxCloud.

girishsontakke changed the title~~resolve #7582~~fix(eslint-plugin): Replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes

Sep 2, 2023

girishsontakke changed the title~~fix(eslint-plugin): Replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes~~fix(eslint-plugin): [no-unsafe-negation] replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes

Sep 2, 2023

auvred requested changes

Sep 2, 2023

View reviewed changes

Copy link

Member

auvred left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please update the other codes according to the existing comments on this PReslint/eslint#17500

typescript-eslint/packages/eslint-plugin/src/configs/eslint-recommended.ts
Line 17 in4899b95
'no-func-assign':'off',// ts(2539)
eslint/eslint#17500 (comment)
typescript-eslint/packages/eslint-plugin/src/configs/eslint-recommended.ts
Line 18 in4899b95
'no-import-assign':'off',// ts(2539) & ts(2540)
eslint/eslint#17500 (comment)

imho these changes don'tfix the behavior of theeslint-plugin and[no-unsafe-negation] rule in particular. It'smore likely adocs. What do you think?

packages/eslint-plugin/src/configs/eslint-recommended.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg requested changes

Sep 2, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What@auvred said 🙂

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Sep 2, 2023

Copy link

ContributorAuthor

girishsontakke commentedSep 4, 2023

Thanks@auvred for the review and the help 🙏. I will add the changes.

girishsontakke changed the title~~fix(eslint-plugin): [no-unsafe-negation] replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes~~docs(eslint-plugin): replaced the Out-of-date TS error codes in eslint-recommended.ts with the supported-codes

Sep 4, 2023

changed the TS error codes

dc0b203

Copy link

codecovbot commentedSep 4, 2023•
edited
Loading

Codecov Report

Merging#7590 (dc0b203) intomain (4899b95) willnot change coverage.
Report is 6 commits behind head on main.
The diff coverage isn/a.

Additional details and impacted files

@@           Coverage Diff           @@##             main    #7590   +/-   ##=======================================  Coverage   87.23%   87.23%           =======================================  Files         387      387             Lines       13401    13401             Branches     3962     3962           =======================================  Hits        11690    11690             Misses       1327     1327             Partials      384      384