Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(utils): add ESLintCodePath selector types#7551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 15 commits intotypescript-eslint:mainfromIsaacScript:interfaces
Nov 13, 2023
Merged

feat(utils): add ESLintCodePath selector types#7551

JoshuaKGoldberg merged 15 commits intotypescript-eslint:mainfromIsaacScript:interfaces
Nov 13, 2023

Conversation

Zamiell
Copy link
Contributor

@ZamiellZamiell commentedAug 28, 2023•
edited
Loading

PR Checklist

Overview

Adds exportedCodePath interfaces and un-commented theonCodePathStart andonCodePathEnd methods, which makes things slightly less painful for people who have custom rules that use this feature.

Based on:#6679

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedAug 28, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit0b1de44
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65523587cb214c00088c1bd0
😎 Deploy Previewhttps://deploy-preview-7551--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedAug 28, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitaa3f504. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
nx run-many --target=lint --parallel
✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

@Zamiell
Copy link
ContributorAuthor

Zamiell commentedAug 29, 2023•
edited
Loading

CI is drunk, the codebase builds just fine for me locally (after my latest commit). Can a maintainer reset the CI cache or something?

@Zamiell
Copy link
ContributorAuthor

Oh, actually on second thought, it just looks like it is failing a spell check on code that is unrelated to my PR, so a maintainer should fix that.

Copy link
Member

@bradzacherbradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looking good so far!

@bradzacherbradzacher added enhancementNew feature or request awaiting responseIssues waiting for a reply from the OP or another party labelsSep 8, 2023
@bradzacherbradzacher changed the titlefeat: add CodePath interfacesfeat(utils): add ESLintCodePath selector typesSep 8, 2023
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelSep 16, 2023
@bradzacherbradzacher added the awaiting responseIssues waiting for a reply from the OP or another party labelNov 10, 2023
@Zamiell
Copy link
ContributorAuthor

ok, i addressed the feedback and merged with the main branch

@bradzacherbradzacher added 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting responseIssues waiting for a reply from the OP or another party labelsNov 12, 2023
@bradzacher
Copy link
Member

For future reference - I'd avoid working from a repo in an org account and instead work from a fork on your personal account. We maintainers can't modify your PR at all - even the standard "update branch" button which auto-merges main doesn't work. This can make it difficult to manage your OSS contributions because we have to ping you and wait for your action even for trivial things like merging main - which we sometimes need to do if main was broken (eg in this case the CI was broken!).

Please merge main so we can kick off the CI again with the latest deps then we can merge this.

JoshuaKGoldberg reacted with thumbs up emoji

@Zamiell
Copy link
ContributorAuthor

Please merge main

done!

@JoshuaKGoldberg
Copy link
Member

...aaaand lint is broken onmain. Sorry 😄 we can just take this as-is and fix linting separately.#7913

@JoshuaKGoldbergJoshuaKGoldberg merged commit99a026f intotypescript-eslint:mainNov 13, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 21, 2023
@ZamiellZamiell deleted the interfaces branchDecember 2, 2023 03:57
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@armano2armano2armano2 left review comments

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergeenhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Support CodePath rule listener methods
4 participants
@Zamiell@bradzacher@JoshuaKGoldberg@armano2
[8]ページ先頭
©2009-2025 Movatter.jp