Aug 17, 2023 · Aug 16, 2023 · Aug 17, 2023
diff --git a/.eslintrc.js b/.eslintrc.js
        null: 'never',
      },
    ],
    'logical-assignment-operators': 'error',
    'no-else-return': 'error',
    'no-mixed-operators': 'error',
    'no-console': 'error',
diff --git a/packages/eslint-plugin/src/rules/consistent-type-imports.ts b/packages/eslint-plugin/src/rules/consistent-type-imports.ts
            ImportDeclaration(node): void {
              const source = node.source.value;
              // sourceImports is the object containing all the specifics for a particular import source, type or value
              const sourceImports =
                sourceImportsMap[source] ??
                (sourceImportsMap[source] = {
                  source,
                  reportValueImports: [], // if there is a mismatch where type importKind but value specifiers
                  typeOnlyNamedImport: null, // if only type imports
                  valueOnlyNamedImport: null, // if only value imports with named specifiers
                  valueImport: null, // if only value imports
                });
              sourceImportsMap[source] ??= {
                source,
                reportValueImports: [], // if there is a mismatch where type importKind but value specifiers
                typeOnlyNamedImport: null, // if only type imports
                valueOnlyNamedImport: null, // if only value imports with named specifiers
                valueImport: null, // if only value imports
              };
              const sourceImports = sourceImportsMap[source];
              if (node.importKind === 'type') {
                if (
                  !sourceImports.typeOnlyNamedImport &&
diff --git a/packages/eslint-plugin/src/rules/unified-signatures.ts b/packages/eslint-plugin/src/rules/unified-signatures.ts
      key?: string,
      containingNode?: ContainingNode,
    ): void {
      key= key ?? getOverloadKey(signature);
      key??= getOverloadKey(signature);
      if (
        currentScope &&
        (containingNode || signature).parent === currentScope.parent
diff --git a/packages/rule-tester/src/utils/config-validator.ts b/packages/rule-tester/src/utils/config-validator.ts
  config: TesterConfigWithDefaults,
  source: string,
 ): void {
  validateSchema= validateSchema || ajv.compile(configSchema);
  validateSchema||= ajv.compile(configSchema);

  if (!validateSchema(config)) {
    throw new Error(
diff --git a/packages/scope-manager/src/referencer/ClassVisitor.ts b/packages/scope-manager/src/referencer/ClassVisitor.ts
     *   ) {}
     * }
     */
    withMethodDecorators =
      withMethodDecorators ||
      (methodNode.kind !== 'set' &&
        node.params.some(param => param.decorators.length));
    withMethodDecorators ||=
      methodNode.kind !== 'set' &&
      node.params.some(param => param.decorators.length);
    if (!withMethodDecorators && methodNode.kind === 'set') {
      const keyName = getLiteralMethodKeyName(methodNode);

diff --git a/packages/typescript-estree/src/create-program/getWatchProgramsForProjects.ts b/packages/typescript-estree/src/create-program/getWatchProgramsForProjects.ts
    if (fileList.has(filePath)) {
      log('Found existing program for file. %s', filePath);

      updatedProgram =
        updatedProgram ?? existingWatch.getProgram().getProgram();
      updatedProgram ??= existingWatch.getProgram().getProgram();
      // sets parent pointers in source files
      updatedProgram.getTypeChecker();

diff --git a/packages/website/src/components/config/ConfigTypeScript.tsx b/packages/website/src/components/config/ConfigTypeScript.tsx
      getTypescriptOptions().reduce<Record<string, ConfigOptionsType>>(
        (group, item) => {
          const category = item.category!.message;
          group[category]= group[category] ?? {
          group[category]??= {
            heading: category,
            fields: [],
          };
Original file line number	Diff line number	Diff line change
Expand Up		@@ -121,6 +121,7 @@ module.exports = {
		null: 'never',
		},
		],
		'logical-assignment-operators': 'error',
Copy link Member JoshuaKGoldbergAug 17, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. [Praise] 👌 and it even respects the existing alphabetical order of rules!!
		'no-else-return': 'error',
		'no-mixed-operators': 'error',
		'no-console': 'error',
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -105,15 +105,14 @@ export default util.createRule<Options, MessageIds>({
		ImportDeclaration(node): void {
		const source = node.source.value;
		// sourceImports is the object containing all the specifics for a particular import source, type or value
		const sourceImports =
		sourceImportsMap[source] ??
		(sourceImportsMap[source] = {
		source,
		reportValueImports: [], // if there is a mismatch where type importKind but value specifiers
		typeOnlyNamedImport: null, // if only type imports
		valueOnlyNamedImport: null, // if only value imports with named specifiers
		valueImport: null, // if only value imports
		});
		sourceImportsMap[source] ??= {
		source,
		reportValueImports: [], // if there is a mismatch where type importKind but value specifiers
		typeOnlyNamedImport: null, // if only type imports
		valueOnlyNamedImport: null, // if only value imports with named specifiers
		valueImport: null, // if only value imports
		};
		const sourceImports = sourceImportsMap[source];
		if (node.importKind === 'type') {
		if (
		!sourceImports.typeOnlyNamedImport &&
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -521,7 +521,7 @@ export default util.createRule<Options, MessageIds>({
		key?: string,
		containingNode?: ContainingNode,
		): void {
		key= key ?? getOverloadKey(signature);
		key??= getOverloadKey(signature);
		if (
		currentScope &&
		(containingNode \|\| signature).parent === currentScope.parent
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -248,7 +248,7 @@ function validateConfigSchema(
		config: TesterConfigWithDefaults,
		source: string,
		): void {
		validateSchema= validateSchema \|\| ajv.compile(configSchema);
		validateSchema\|\|= ajv.compile(configSchema);

		if (!validateSchema(config)) {
		throw new Error(
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -154,10 +154,9 @@ class ClassVisitor extends Visitor {
		* ) {}
		* }
		*/
		withMethodDecorators =
		withMethodDecorators \|\|
		(methodNode.kind !== 'set' &&
		node.params.some(param => param.decorators.length));
		withMethodDecorators \|\|=
		methodNode.kind !== 'set' &&
		node.params.some(param => param.decorators.length);
		if (!withMethodDecorators && methodNode.kind === 'set') {
		const keyName = getLiteralMethodKeyName(methodNode);

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -180,8 +180,7 @@ function getWatchProgramsForProjects(
		if (fileList.has(filePath)) {
		log('Found existing program for file. %s', filePath);

		updatedProgram =
		updatedProgram ?? existingWatch.getProgram().getProgram();
		updatedProgram ??= existingWatch.getProgram().getProgram();
		// sets parent pointers in source files
		updatedProgram.getTypeChecker();

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -35,7 +35,7 @@ function ConfigTypeScript(props: ConfigTypeScriptProps): React.JSX.Element {
		getTypescriptOptions().reduce<Record<string, ConfigOptionsType>>(
		(group, item) => {
		const category = item.category!.message;
		group[category]= group[category] ?? {
		group[category]??= {
		heading: category,
		fields: [],
		};
Expand Down