Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: enable logical-assignment-operators rule internally#7484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@NotWoods
Copy link
Contributor

PR Checklist

Overview

Enables logical-assignment-operators rule and fixes all violations

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@NotWoods!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedAug 16, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitab41152
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/64dc53f3f8aa5d0008ec2a35
😎 Deploy Previewhttps://deploy-preview-7484--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedAug 16, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitab41152. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 37 targets

Sent with 💌 fromNxCloud.

@NotWoodsNotWoods changed the titleEnable logical-assignment-operators rule internallychore: enable logical-assignment-operators rule internallyAug 16, 2023
null:'never',
},
],
'logical-assignment-operators':'error',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Praise] 👌 and it even respects the existing alphabetical order of rules!!

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love it, thanks as always@NotWoods! 🚀 🧹

@JoshuaKGoldbergJoshuaKGoldberg merged commit66cc514 intotypescript-eslint:mainAug 17, 2023
@NotWoodsNotWoods deleted the enable-logical-assignment-operators branchAugust 18, 2023 02:45
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 26, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: Enable logical-assignment-operators internally?

2 participants

@NotWoods@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp