Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [await-thenable] added suggestion fixer#7437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds asuggestion fixer to removeawait from the beginning of the AwaitExpression.

While I was in the area, split up theinvalid test cases (#6887).

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedAug 7, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit73d4a8c
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/64f3fdb47a49110008f9bf37
😎 Deploy Previewhttps://deploy-preview-7437--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedAug 7, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit73d4a8c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 40 targets

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedAug 7, 2023•
edited
Loading

Codecov Report

Merging#7437 (73d4a8c) intomain (0a1de14) willdecrease coverage by0.19%.
Report is 76 commits behind head on main.
The diff coverage is100.00%.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #7437      +/-   ##==========================================- Coverage   87.41%   87.23%   -0.19%==========================================  Files         381      387       +6       Lines       13321    13404      +83       Branches     3938     3962      +24     ==========================================+ Hits        11645    11693      +48- Misses       1298     1327      +29- Partials      378      384       +6
FlagCoverage Δ
unittest87.23% <100.00%> (-0.19%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files ChangedCoverage Δ
packages/eslint-plugin/src/rules/await-thenable.ts100.00% <100.00%> (ø)

... and22 files with indirect coverage changes

armano2
armano2 previously approved these changesSep 2, 2023
@bradzacherbradzacher changed the titlefeat(eslint-plugin): added suggestion fixer to await-thenablefeat(eslint-plugin): [await-thenable] added suggestion fixerSep 7, 2023
@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 7, 2023
@JoshuaKGoldbergJoshuaKGoldberg merged commitb284370 intotypescript-eslint:mainSep 8, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the await-thenable-fixer branchSeptember 8, 2023 11:54
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

+1 more reviewer

@armano2armano2armano2 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: [await-thenable] Add a suggestion fixer

3 participants

@JoshuaKGoldberg@armano2@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp