Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: addno-unsafe-unary-minus rule#7390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 8 commits intotypescript-eslint:mainfromsamestep:unary-minus
Nov 13, 2023
Merged

feat: addno-unsafe-unary-minus rule#7390

JoshuaKGoldberg merged 8 commits intotypescript-eslint:mainfromsamestep:unary-minus
Nov 13, 2023

Conversation

samestep
Copy link
Contributor

@samestepsamestep commentedJul 31, 2023•
edited
Loading

PR Checklist

Overview

This PR pulls the implementation of thenpm packageeslint-plugin-unary-minus into this repo, then modifies it to avoid using theTypeChecker methodsgetUnionType andisTypeAssignableTo which are not public in the TypeScript API; seemicrosoft/TypeScript#9879.

auvred reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@samestep!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJul 31, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit86b634a
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/653ead7872c36b0008b3cb11
😎 Deploy Previewhttps://deploy-preview-7390--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedJul 31, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit86b634a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A solid start, thanks for sending in! ✨

Requesting changes on using more direct, public APIs, and some more testing.

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelAug 5, 2023
@JoshuaKGoldberg
Copy link
Member

👋 Hey@samestep! Just checking in, is this still something you have time for? No worries if not - I just don't want to leave it hanging.

@JoshuaKGoldbergJoshuaKGoldberg added the stalePRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period labelOct 17, 2023
@samestep
Copy link
ContributorAuthor

@JoshuaKGoldberg thanks for the ping! Sorry for dropping the ball on this; I'm taking a look now, will see if I can figure out how to restructure it according to the feedback you gave in August.

JoshuaKGoldberg reacted with heart emoji

@JoshuaKGoldbergJoshuaKGoldberg removed the stalePRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period labelOct 29, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking great! A few comments, mostly more questions than anything else. But I am starting to wonder about increasing the rule's scope... 🤔

@bradzacherbradzacher added the enhancement: new plugin ruleNew rule request for eslint-plugin labelNov 13, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀 swell, thanks!

samestep reacted with heart emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commitc4709c2 intotypescript-eslint:mainNov 13, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 21, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Josh-CenaJosh-CenaJosh-Cena left review comments

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another partyenhancement: new plugin ruleNew rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: no-implicit-coercion using a negative/minus (-) symbol
4 participants
@samestep@JoshuaKGoldberg@Josh-Cena@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp