typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(eslint-plugin): [no-restricted-imports] allow inline type qualifiers when`allowTypeImports` enabled#7379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromauvred:fix/7374

Aug 5, 2023

Merged

fix(eslint-plugin): [no-restricted-imports] allow inline type qualifiers when`allowTypeImports` enabled#7379

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromauvred:fix/7374

Aug 5, 2023

Conversation

Copy link

Member

auvred commentedJul 30, 2023

PR Checklist

Addresses an existing open issue:fixesBug: [no-restricted-imports]allowTypeImports should allow inline type qualifiers #7374
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

If kind of every specifier in import/export declaration istype, then the entire declaration is treated as type-only

The issue was about exports, but I guess this should be applicable to imports too

fix(eslint-plugin): [no-restricted-imports] allow inline type qualifi…

43f4e57

…ers when `allowTypeImports` enabled

Copy link

Contributor

typescript-eslintbot commentedJul 30, 2023

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 30, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`f99bfe1`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64cea73d226ed80008a0a9fc
😎 Deploy Preview	https://deploy-preview-7379--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJul 30, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf99bfe1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 35 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedJul 30, 2023•
edited
Loading

Codecov Report

Merging#7379 (43f4e57) intomain (c869aa1) willincrease coverage by0.01%.
Report is 40 commits behind head on main.
The diff coverage is67.56%.

❗ Current head43f4e57 differs from pull request most recent headf99bfe1. Consider uploading reports for the commitf99bfe1 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##             main    #7379      +/-   ##==========================================+ Coverage   87.40%   87.41%   +0.01%==========================================  Files         381      381                Lines       13313    13321       +8       Branches     3934     3939       +5     ==========================================+ Hits        11636    11645       +9- Misses       1292     1298       +6+ Partials      385      378       -7

Flag	Coverage Δ
unittest	`87.41% <67.56%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files Changed	Coverage Δ
...kages/scope-manager/src/referencer/ClassVisitor.ts	`91.73% <ø> (ø)`
packages/type-utils/src/predicates.ts	`21.73% <0.00%> (ø)`
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts	`93.33% <ø> (ø)`
packages/typescript-estree/src/convert.ts	`30.03% <31.25%> (ø)`
...eslint-plugin/src/rules/type-annotation-spacing.ts	`83.09% <50.00%> (+1.40%)`	⬆️
...eslint-plugin/src/rules/consistent-type-imports.ts	`94.50% <100.00%> (ø)`
packages/eslint-plugin/src/rules/indent.ts	`88.09% <100.00%> (ø)`
packages/eslint-plugin/src/rules/key-spacing.ts	`99.30% <100.00%> (ø)`
...es/eslint-plugin/src/rules/no-floating-promises.ts	`100.00% <100.00%> (ø)`
...ges/eslint-plugin/src/rules/no-inferrable-types.ts	`95.23% <100.00%> (+0.23%)`	⬆️
... and10 more