Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: blog post on parserOptions.project = true#7368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJul 28, 2023•
edited
Loading

PR Checklist

Overview

Adds a blog post explaining:

  • The current state ofparserOptions.project options
  • Why we addedproject: true
  • Benefits of that new option
  • How it works at a very high level
  • Next steps

References:

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJul 28, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit0368db6
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6500b3257be7fe00083eff4c
😎 Deploy Previewhttps://deploy-preview-7368--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldbergJoshuaKGoldberg added the DO NOT MERGEPRs which should not be merged yet labelJul 28, 2023
@nx-cloud
Copy link

nx-cloudbot commentedJul 28, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0368db6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 20 targets

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedJul 28, 2023•
edited
Loading

Codecov Report

Merging#7368 (fbcc812) intomain (4f34d0b) willincrease coverage by0.00%.
Report is 46 commits behind head on main.
The diff coverage isn/a.

❗ Current headfbcc812 differs from pull request most recent head0368db6. Consider uploading reports for the commit0368db6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@##             main    #7368   +/-   ##=======================================  Coverage   87.23%   87.23%           =======================================  Files         387      387             Lines       13401    13404    +3       Branches     3962     3962           =======================================+ Hits        11690    11693    +3  Misses       1327     1327             Partials      384      384
FlagCoverage Δ
unittest87.23% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 3 files with indirect coverage changes

@JoshuaKGoldbergJoshuaKGoldberg changed the titleWIP: blog post on parserOptions.project = truedocs: blog post on parserOptions.project = trueJul 30, 2023
@JoshuaKGoldbergJoshuaKGoldberg removed the DO NOT MERGEPRs which should not be merged yet labelJul 30, 2023
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewJuly 30, 2023 22:20
bradzacher
bradzacher previously approved these changesSep 7, 2023
@bradzacherbradzacher added documentationDocumentation ("docs") that needs adding/updating 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelsSep 7, 2023
Copy link
Member

@Josh-CenaJosh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some nits

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
bradzacher
bradzacher previously approved these changesSep 8, 2023
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Copy link
Member

@Josh-CenaJosh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

JoshuaKGoldberg reacted with rocket emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commitded5d21 intotypescript-eslint:mainSep 16, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the parser-options-project-true branchSeptember 16, 2023 21:32
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 24, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@armano2armano2armano2 left review comments

@Josh-CenaJosh-CenaJosh-Cena approved these changes

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergedocumentationDocumentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Add post on parserOptions.project = true
4 participants
@JoshuaKGoldberg@armano2@bradzacher@Josh-Cena
[8]ページ先頭
©2009-2025 Movatter.jp