Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
chore: get the TypeScript version range from root package.json#7367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedJul 28, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
nx-cloudbot commentedJul 28, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
For the hardcodings that are making things more difficult, I think it's ok to skip them for now. We can always file a followup issue to revisit. I'd rather get this partially fixed than wait on weird intricacies. Worst case scenario, I bet |
Hi! I looked through the So, should I skip last two tasks for now? |
Yeah let's skip for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💯 love it, thanks@auvred!
I can file a followup issue on the postponed stuff.
codecovbot commentedAug 5, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #7367 +/- ##======================================= Coverage 87.41% 87.41% ======================================= Files 381 381 Lines 13316 13316 Branches 3936 3936 ======================================= Hits 11640 11640 Misses 1298 1298 Partials 378 378
Flags with carried forward coverage won't be shown.Click here to find out more. |
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
Overview
The goal of this PR is to refactor all possible places where the TypeScript version/version range is hardcoded and might be taken from the root
package.json
.I found the following places (but there may be a few more here):
Typescript version range in
docs/users/Dependency_Versions.mdx
typescript-eslint/docs/users/Dependency_Versions.mdx
Line 19 ind89b847
Available TypeScript versions in the playground (thanks toRepo: Automate version ranges in website's Versioning.md #6389 (comment))
Now it contains only versions that satisfy version range from root

package.json
Typescript version range in
docs/users/Versioning.mdx
Will beRemoved indocs: remove duplicated package versions description #7343typescript-eslint/docs/users/Versioning.mdx
Line 51 ind89b847
[Postponed]Probably this range also should be taken from the root
package.json
(Maybe I'm wrong)typescript-eslint/packages/typescript-estree/src/parseSettings/warnAboutTSVersion.ts
Lines 5 to 9 ind89b847
"rootDir": "."
in thetsconfig.json
typescript-eslint/packages/typescript-estree/tsconfig.json
Line 5 ind89b847
typescript-eslint/packages/typescript-estree/tsconfig.build.json
Line 6 ind89b847
So we can't just import
package.json
from the repository root. Is there any other way do get this done? Or this constant and range inpackage.json
must be independent?[Postponed]Also not sure what to do with this list
Should it also be updated automatically?
typescript-eslint/packages/typescript-estree/src/version-check.ts
Lines 14 to 23 ind89b847