Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: get the TypeScript version range from root package.json#7367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 5 commits intotypescript-eslint:mainfromauvred:chore/6389
Aug 5, 2023

Conversation

auvred
Copy link
Member

@auvredauvred commentedJul 28, 2023
edited
Loading

PR Checklist

Overview

The goal of this PR is to refactor all possible places where the TypeScript version/version range is hardcoded and might be taken from the rootpackage.json.

I found the following places (but there may be a few more here):

Josh-Cena and JoshuaKGoldberg reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJul 28, 2023
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitbf4911a
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/64ceafc89f18160008d58ab4
😎 Deploy Previewhttps://deploy-preview-7367--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedJul 28, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitbf4911a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 35 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldberg
Copy link
Member

For the hardcodings that are making things more difficult, I think it's ok to skip them for now. We can always file a followup issue to revisit. I'd rather get this partially fixed than wait on weird intricacies.

Worst case scenario, I betwebsite-eslint could include version ranges...

@auvred
Copy link
MemberAuthor

Hi! I looked through thewebsite-eslint and didn't find anything there at all about the typescript versions.

So, should I skip last two tasks for now?

@JoshuaKGoldberg
Copy link
Member

Yeah let's skip for now

auvred reacted with thumbs up emoji

@auvredauvred marked this pull request as ready for reviewJuly 31, 2023 15:56
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 love it, thanks@auvred!

I can file a followup issue on the postponed stuff.

auvred reacted with heart emoji
@codecov
Copy link

codecovbot commentedAug 5, 2023
edited
Loading

Codecov Report

Merging#7367 (2323c06) intomain (dfcafae) willnot change coverage.
Report is 5 commits behind head on main.
The diff coverage isn/a.

❗ Current head2323c06 differs from pull request most recent headbf4911a. Consider uploading reports for the commitbf4911a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@##             main    #7367   +/-   ##=======================================  Coverage   87.41%   87.41%           =======================================  Files         381      381             Lines       13316    13316             Branches     3936     3936           =======================================  Hits        11640    11640             Misses       1298     1298             Partials      378      378
FlagCoverage Δ
unittest87.41% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

see 1 file with indirect coverage changes

@JoshuaKGoldbergJoshuaKGoldberg merged commit8352759 intotypescript-eslint:mainAug 5, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Automate version ranges in website's Versioning.md
2 participants
@auvred@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp