Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: enable consistent-indexed-object-style and lint#7353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

nevvada
Copy link
Contributor

@nevvadanevvada commentedJul 28, 2023•
edited
Loading

PR Checklist

Overview

this PR:

  • enablesconsistent-indexed-object-style eslint rule
  • addresses all files that had lint errors due to this rule previously being ignored

all updated instances were legitimate places that needed to be updated per the lint rule

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@nevvada!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJul 28, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit43dc20b
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/64cea78dc682b10008dcfc7f
😎 Deploy Previewhttps://deploy-preview-7353--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedJul 28, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit43dc20b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 35 targets

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedJul 28, 2023•
edited
Loading

Codecov Report

Merging#7353 (316e7df) intomain (c869aa1) willincrease coverage by0.01%.
Report is 40 commits behind head on main.
The diff coverage is65.21%.

❗ Current head316e7df differs from pull request most recent head43dc20b. Consider uploading reports for the commit43dc20b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##             main    #7353      +/-   ##==========================================+ Coverage   87.40%   87.41%   +0.01%==========================================  Files         381      381                Lines       13313    13316       +3       Branches     3934     3936       +2     ==========================================+ Hits        11636    11640       +4- Misses       1292     1298       +6+ Partials      385      378       -7
FlagCoverage Δ
unittest87.41% <65.21%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files ChangedCoverage Δ
packages/type-utils/src/predicates.ts21.73% <0.00%> (ø)
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts93.33% <ø> (ø)
packages/typescript-estree/src/simple-traverse.ts72.72% <ø> (ø)
packages/utils/src/ts-eslint/CLIEngine.ts33.33% <ø> (ø)
packages/utils/src/ts-eslint/Linter.ts50.00% <ø> (ø)
packages/utils/src/ts-eslint/SourceCode.ts50.00% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts30.03% <31.25%> (ø)
...eslint-plugin/src/rules/type-annotation-spacing.ts83.09% <50.00%> (+1.40%)⬆️
...eslint-plugin/src/rules/consistent-type-exports.ts97.67% <100.00%> (ø)
... and14 more

@@ -69,9 +69,7 @@ function compileSchema(

const refMap = new Map<string, string>();
// we only support defs at the top level for simplicity
const defs = (schema.$defs ?? schema.definitions) as
| Record<string, JSONSchema4>
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

removed this one sinceschema.$defs andschema.definitions are bothRecord<string, JSONSchema4> | undefined;

image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice!

@nevvadanevvada marked this pull request as ready for reviewJuly 29, 2023 00:51
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesAug 5, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! 🎉

I can apply the suggestion & merge in.

@JoshuaKGoldbergJoshuaKGoldberg merged commit4087f48 intotypescript-eslint:mainAug 5, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@nevvada@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp