Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: remove duplicated package versions description#7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromauvred:docs/7341
Jul 28, 2023

Conversation

auvred
Copy link
Member

PR Checklist

Overview

Reverting hunk from this merge commitc233652, according to#7341 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJul 27, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit48c4474
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/64c41b3061290f00080d3e2b
😎 Deploy Previewhttps://deploy-preview-7343--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedJul 27, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit48c4474. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 35 targets

Sent with 💌 fromNxCloud.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for starting on this! I think the general direction is good, but because of the merge shenanigans there's additional info on this page we'd want to preserve.

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelJul 27, 2023
@auvred
Copy link
MemberAuthor

I guess I added all missed stuff :)

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very close! Just a bit more stuff that I don't see in the new form. I think we'll be good to go once that's added back in (or I'm told I just did a silly and missed them?). 🚀

auvred reacted with heart emoji
@codecov
Copy link

codecovbot commentedJul 28, 2023•
edited
Loading

Codecov Report

Merging#7343 (48c4474) intomain (54ef459) willincrease coverage by0.01%.
Report is 6 commits behind head on main.
The diff coverage isn/a.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #7343      +/-   ##==========================================+ Coverage   87.40%   87.41%   +0.01%==========================================  Files         381      381                Lines       13313    13316       +3       Branches     3934     3936       +2     ==========================================+ Hits        11636    11640       +4- Misses       1292     1298       +6+ Partials      385      378       -7
FlagCoverage Δ
unittest87.41% <ø> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 16 files with indirect coverage changes

@auvred
Copy link
MemberAuthor

Excuse me for my inattention, documentation is not my strongest point 😓

JoshuaKGoldberg reacted with heart emoji

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wonderful, thanks! 🙌

auvred reacted with rocket emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commit33b936d intotypescript-eslint:mainJul 28, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Two pages describe package versions
2 participants
@auvred@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp