Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: enabled most of strict-type-checked internally#7339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Ranyarn lint --fix and disabled a couple rules with alot of complaints.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJul 27, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitd3fe48e
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/653167f45050f30008a2cb6b
😎 Deploy Previewhttps://deploy-preview-7339--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedJul 27, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitd3fe48e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

@bradzacherbradzacher added the repo maintenancethings to do with maintenance of the repo, and not with code/docs labelJul 28, 2023
bradzacher
bradzacher previously approved these changesJul 28, 2023
@@ -1,3 +1,4 @@
/* eslint-disable @typescript-eslint/prefer-literal-enum-member */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

enumArgumentType{Other=0,String=1<<0,RegExp=1<<1,Both=String|RegExp,}

🤮

JoshuaKGoldberg reacted with laugh emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Doesn't it make you feel like a pro? 😎

JoshuaKGoldberg reacted with laugh emoji
string,
TSESLint.RuleModule<string, readonly unknown[], TSESLint.RuleListener>,
];
type RuleEntry = [string, TSESLint.RuleModule<string, readonly unknown[]>];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TODO - should really migrate toimport { RuleModule } from '@typescript-eslint/utils/ts-eslint'
That was the entire reason for adding the export maps

JoshuaKGoldberg reacted with thumbs up emoji
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
bradzacher
bradzacher previously approved these changesJul 28, 2023
@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelSep 7, 2023
@JoshuaKGoldbergJoshuaKGoldberg merged commit4972ecd intotypescript-eslint:mainOct 19, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the enable-strict-internally branchOctober 19, 2023 20:28
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Josh-CenaJosh-CenaJosh-Cena left review comments

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergerepo maintenancethings to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Enable strict & stylistic configs internally
3 participants
@JoshuaKGoldberg@bradzacher@Josh-Cena
[8]ページ先頭
©2009-2025 Movatter.jp