feat(eslint-plugin): [prefer-nullish-coalescing] allow`ignorePrimitives` option to be`true`#7331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromauvred:feat/7180

Aug 5, 2023

Merged

feat(eslint-plugin): [prefer-nullish-coalescing] allow`ignorePrimitives` option to be`true`#7331

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromauvred:feat/7180

Aug 5, 2023

Conversation

Copy link

Member

auvred commentedJul 27, 2023•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesEnhancement: [prefer-nullish-coalescing] Allow ignorePrimitives option to be true #7180
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Not sure if I need to add an invalid tests case for such a change

feat(eslint-plugin): [prefer-nullish-coalescing] allow `ignorePrimiti…

ee78d92

…ves` option to be `true`

Copy link

Contributor

typescript-eslintbot commentedJul 27, 2023

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 27, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`4b906b3`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64c299eee7acfd000818e942
😎 Deploy Preview	https://deploy-preview-7331--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

chore: update test snapshot

4b906b3

Copy link

nx-cloudbot commentedJul 27, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4b906b3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 35 targets