feat(eslint-plugin)!: [promise-function-async] make allowAny default true#733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JamesHenry merged 2 commits intomasterfrompfa-default-opts

Jul 21, 2019

Merged

feat(eslint-plugin)!: [promise-function-async] make allowAny default true#733

JamesHenry merged 2 commits intomasterfrompfa-default-opts

Jul 21, 2019

Conversation

Copy link

Member

bradzacher commentedJul 20, 2019•
edited
Loading

BREAKING CHANGE: changing default rule config

Having functions that returnany be considered async is weird. I left the option in just in case someone wants this functinoality.
#501 (comment)

feat(eslint-plugin): [promise-function-async] make allowAny default true

0be054e

BREAKING: changing default rule config

bradzacher added enhancement

New feature or request

breaking changeThis change will require a new major version to be released labels

Jul 20, 2019

bradzacher added this to the2.0.0 milestone

Jul 20, 2019

bradzacher mentioned this pull request

Jul 20, 2019

2.0.0 Breaking Changes#501

Closed

14 tasks

bradzacher changed the title~~feat(eslint-plugin): [promise-function-async] make allowAny default true~~feat(eslint-plugin)!: [promise-function-async] make allowAny default true

Jul 21, 2019

JamesHenry approved these changes

Jul 21, 2019

View reviewed changes

Merge branch 'master' into pfa-default-opts

0399780

Copy link

codecovbot commentedJul 21, 2019

Codecov Report

Merging#733 intomaster willdecrease coverage by0.03%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master     #733      +/-   ##==========================================- Coverage   94.45%   94.41%   -0.04%==========================================  Files         113      113                Lines        4705     4711       +6       Branches     1288     1293       +5     ==========================================+ Hits         4444     4448       +4  Misses        150      150- Partials      111      113       +2

Impacted Files	Coverage Δ
.../eslint-plugin/src/rules/promise-function-async.ts	`100% <ø> (ø)`	⬆️
packages/eslint-plugin/src/util/misc.ts	`80.95% <0%> (-3.26%)`	⬇️
...-plugin/src/rules/explicit-member-accessibility.ts	`88.23% <0%> (-1.35%)`	⬇️
...nt-plugin/src/rules/indent-new-do-not-use/index.ts	`98.39% <0%> (ø)`	⬆️
...-plugin/src/rules/explicit-function-return-type.ts	`100% <0%> (ø)`	⬆️
packages/eslint-plugin/src/rules/array-type.ts	`91.35% <0%> (ø)`	⬆️
...ges/experimental-utils/src/ts-eslint/RuleTester.ts	`0% <0%> (ø)`	⬆️