Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin)!: add ruleconsistent-type-assertions#731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 8 commits intomasterfromconsistent-type-assertions
Jul 25, 2019

Conversation

bradzacher
Copy link
Member

@bradzacherbradzacher commentedJul 20, 2019•
edited
Loading

BREAKING CHANGE: Merges bothno-angle-bracket-type-assertion andno-object-literal-type-assertion into one rule

Fixes#332
Fixes#668

Merges both `no-angle-bracket-type-assertion` and `no-object-literal-type-assertion` into one ruleFixes#332Fixes#668
@bradzacherbradzacher added the enhancement: new plugin ruleNew rule request for eslint-plugin labelJul 20, 2019
@bradzacherbradzacher mentioned this pull requestJul 20, 2019
14 tasks
@bradzacherbradzacher added this to the2.0.0 milestoneJul 20, 2019
@JamesHenryJamesHenry added the breaking changeThis change will require a new major version to be released labelJul 21, 2019
@bradzacherbradzacher changed the titlefeat(eslint-plugin): add ruleconsistent-type-assertionsfeat(eslint-plugin)!: add ruleconsistent-type-assertionsJul 22, 2019
@JamesHenry
Copy link
Member

@bradzacher Linting failed on this one, looks like we are still using the deleted rules as of the current commit, so it is failing to find them

@bradzacher
Copy link
MemberAuthor

oops forgot about the recommended config

@codecov
Copy link

codecovbot commentedJul 25, 2019

Codecov Report

Merging#731 intomaster willdecrease coverage by0.13%.
The diff coverage is73.68%.

@@            Coverage Diff             @@##           master     #731      +/-   ##==========================================- Coverage   94.47%   94.34%   -0.14%==========================================  Files         112      111       -1       Lines        4721     4735      +14       Branches     1307     1315       +8     ==========================================+ Hits         4460     4467       +7- Misses        150      156       +6- Partials      111      112       +1
Impacted FilesCoverage Δ
...l-utils/src/eslint-utils/batchedSingleLineTests.ts0% <0%> (ø)⬆️
packages/eslint-plugin/src/rules/index.ts100% <100%> (ø)⬆️
...int-plugin/src/rules/consistent-type-assertions.ts87.09% <87.09%> (ø)

@JamesHenryJamesHenry merged commit92e98de intomasterJul 25, 2019
@JamesHenryJamesHenry deleted the consistent-type-assertions branchJuly 25, 2019 00:14
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry left review comments

Assignees
No one assigned
Labels
breaking changeThis change will require a new major version to be releasedenhancement: new plugin ruleNew rule request for eslint-plugin
Projects
None yet
Milestone
2.0.0
2 participants
@bradzacher@JamesHenry
[8]ページ先頭
©2009-2025 Movatter.jp