Codecov Report

Merging#729 intomaster willdecrease coverage by0.01%.
The diff coverage is89.47%.

@@            Coverage Diff             @@##           master     #729      +/-   ##==========================================- Coverage   94.21%   94.19%   -0.02%==========================================  Files         112      112                Lines        4821     4825       +4       Branches     1336     1338       +2     ==========================================+ Hits         4542     4545       +3- Misses        159      160       +1  Partials      120      120

@bradzacher Should thedocumentation also be updated?

Is there a full list of what was removed? We upgraded to the latest 2.x release from 1.x and notice a bunch of stuff (likeno-console) that we rely on was removed, but I've looked through this issue and the PRs and I don't see a comprehensive list.

We'd like to put the recommended ones back in because we have a huge code base that relied on them. Thank you!

@bbugh
You're probably looking for eslint's recommended list, which changed between eslint 5 and eslint 6:
https://github.com/eslint/eslint/blob/master/conf/eslint-recommended.js

We only change our configs, which are found here:
https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin/src/configs

If you look at#651, you'll see an in-depth list of every single rule, and why or why not it was included in our v2 list.

As an aside, have a look at my personal config repo:
https://github.com/bradzacher/eslint-config-brad

In there I have tooling which strictly types config files to ensure I'm configuring rules correctly, and to ensure that I've configured every single available rule.

I strongly recommend that any appropriately large codebase should take ownership of their eslint config, and think about every single rule.

It will take a few hours to do e2e, sure, but the wins in terms of strict code style, error catching, etc are completely worth it for a large project.