We should be able to report on things likea() = 1 and1 = 1 as well, but I didn't do this because things like{ a } = 1 makes it a little more complicated.

Copy link

Contributor

typescript-eslintbot commentedJul 12, 2023

Thanks for the PR,@Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJul 12, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`d6d6d70`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/657a67374fea510008a9a791
😎 Deploy Preview	https://deploy-preview-7202--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJul 12, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit94cc251. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

🟥 Failed Commands
`nx test eslint-plugin --coverage=false`

✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

bradzacher added the enhancementNew feature or request label

Jul 17, 2023

Copy link

Member

bradzacher commentedJul 17, 2023•
edited
Loading

I had a look at the TS codebase and it's a bit messy with regard to this class of errors.

Here's a few snippets I can find:

I can't link thechecker.ts file in GH cos it's too big but here are the relevant lines:

functioncheckReferenceExpression(expr:Expression,invalidReferenceMessage:DiagnosticMessage,invalidOptionalChainMessage:DiagnosticMessage):boolean{// References are combinations of identifiers, parentheses, and property accesses.constnode=skipOuterExpressions(expr,OuterExpressionKinds.Assertions|OuterExpressionKinds.Parentheses);if(node.kind!==SyntaxKind.Identifier&&!isAccessExpression(node)){error(expr,invalidReferenceMessage);returnfalse;}if(node.flags&NodeFlags.OptionalChain){error(expr,invalidOptionalChainMessage);returnfalse;}returntrue;}

exportfunctionisAccessExpression(node:Node):node isAccessExpression{returnnode.kind===SyntaxKind.PropertyAccessExpression||node.kind===SyntaxKind.ElementAccessExpression;}

and

functioncheckReferenceAssignment(target:Expression,sourceType:Type,checkMode?:CheckMode):Type{consttargetType=checkExpression(target,checkMode);consterror=target.parent.kind===SyntaxKind.SpreadAssignment ?Diagnostics.The_target_of_an_object_rest_assignment_must_be_a_variable_or_a_property_access :Diagnostics.The_left_hand_side_of_an_assignment_expression_must_be_a_variable_or_a_property_access;constoptionalError=target.parent.kind===SyntaxKind.SpreadAssignment ?Diagnostics.The_target_of_an_object_rest_assignment_may_not_be_an_optional_property_access :Diagnostics.The_left_hand_side_of_an_assignment_expression_may_not_be_an_optional_property_access;if(checkReferenceExpression(target,error,optionalError)){checkTypeAssignableToAndOptionallyElaborate(sourceType,targetType,target,target);}if(isPrivateIdentifierPropertyAccessExpression(target)){checkExternalEmitHelpers(target.parent,ExternalEmitHelpers.ClassPrivateFieldSet);}returnsourceType;}functioncheckReferenceExpression(expr:Expression,invalidReferenceMessage:DiagnosticMessage,invalidOptionalChainMessage:DiagnosticMessage):boolean{// References are combinations of identifiers, parentheses, and property accesses.constnode=skipOuterExpressions(expr,OuterExpressionKinds.Assertions|OuterExpressionKinds.Parentheses);if(node.kind!==SyntaxKind.Identifier&&!isAccessExpression(node)){error(expr,invalidReferenceMessage);returnfalse;}if(node.flags&NodeFlags.OptionalChain){error(expr,invalidOptionalChainMessage);returnfalse;}returntrue;}

exportfunctionisPrivateIdentifierPropertyAccessExpression(node:Node):node isPrivateIdentifierPropertyAccessExpression{returnisPropertyAccessExpression(node)&&isPrivateIdentifier(node.name);}

JoshuaKGoldberg previously approved these changes

Jul 17, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - glad you're diving into this@Josh-Cena!

@bradzacher - since you commented in the issue I'll wait for your review for a bit.

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Jul 17, 2023

bradzacher requested changes

Jul 18, 2023

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These are also semantically valid assignment:

declareletx:1;(xas1)=1;(<1>x)=1;(xsatisfies1)=1;

Which is covered by theskipOuterExpressions(expr, OuterExpressionKinds.Assertions | OuterExpressionKinds.Parentheses); line in the TS codebase.

Also currently this is invalid (for now):

declareconsty:{z:number};y?.z=1;

I don't know if we have handling for cases like this (if we don't - do we want to add them in this PR?):

declareconstz:string[];let[ ...a=[]]=z;let{ ...b={}}=z;

Other than that looking good!

bradzacher added awaiting responseIssues waiting for a reply from the OP or another party and removed 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels

Jul 18, 2023

Copy link

MemberAuthor

Josh-Cena commentedJul 18, 2023

let[ ...a=[]]=z;let{ ...b={}}=z;

This PR only deals with update expressions, not assignment or declaration, so not those atm.

I'll add the assertion ones.

Josh-Cena dismissedJoshuaKGoldberg’sstale review viade37a7f

July 18, 2023 14:07

fisker reviewed

Jul 23, 2023

View reviewed changes

packages/typescript-estree/src/convert.ts OutdatedShow resolvedHide resolved

Copy link

Contributor

fisker commentedJul 23, 2023

@Josh-Cena

Side question: when I work on invalid AST checks, I feel it's hard to debug, maybe we need find a better way to run test on single fixture, do you feel the same?

Copy link

Member

bradzacher commentedJul 23, 2023

@fisker I did build this into the infra to make it possible to filter the tests:

https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/ast-spec/tests/fixtures.test.ts#L21-L25

But I agree that it's not a very good DevX and pretty hacky. Open to suggestions to improve it!

Copy link

Contributor

fisker commentedJul 28, 2023•
edited
Loading

I hope we run test from each directory, so we can
jest packages/ast-spec/src/expression/UpdateExpression/fixtures/_error_/literal/.

Josh-Cena requested a review frombradzacher

July 28, 2023 16:41

JoshuaKGoldberg removed the awaiting responseIssues waiting for a reply from the OP or another party label

Oct 18, 2023

bradzacher requested changes

Nov 10, 2023

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just one comment otherwise

packages/typescript-estree/src/node-utils.ts

		}
		return true;
		case SyntaxKind.ParenthesizedExpression:
		case SyntaxKind.TypeAssertionExpression:

Copy link

Member

bradzacherNov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I might have missed it but I think we're missing a case for this

Copy link

MemberAuthor

Josh-CenaNov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@bradzacher Wow, thanks for catching that! In doing so I realizedTypeAssertionExpression is only for<number>foo andfoo as number is a separate syntax kind.

bradzacher added awaiting response

Issues waiting for a reply from the OP or another party

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels

Nov 10, 2023

Josh-Cenaand others added5 commits

November 23, 2023 13:41

feat(typescript-estree): throw on invalid update expressions

79e6008

Test parens

331216c

Handle optional chain + assertion

23b9921

Update packages/typescript-estree/src/convert.ts

79726b8

Co-authored-by: fisker Cheung <lionkay@gmail.com>

Update snapshot

a9918d3

Josh-Cena force-pushed theinvalid-update branch from94cc251 toa9918d3Compare

November 23, 2023 18:41

Add test cases, add satisfies & as

548a792

Josh-Cena requested a review frombradzacher

November 23, 2023 19:06

Josh-Cena removed the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 23, 2023

Merge branch 'main' into invalid-update

b202773

bradzacher added the awaiting responseIssues waiting for a reply from the OP or another party label

Dec 6, 2023

bradzacher previously approved these changes

Dec 6, 2023

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just need to get CI passing and we can merge this

Fix fixtures?

97b9d04

Josh-Cena dismissedbradzacher’sstale review via97b9d04

December 8, 2023 01:16

Josh-Cena added3 commits

December 12, 2023 18:06

Merge branch 'master' into invalid-update

9d2689c

Fix?

d709adf

Fix tests

8c60dc9

This comment was marked as outdated.

Josh-Cena requested a review frombradzacher

December 13, 2023 00:35

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Dec 13, 2023

Merge branch 'master' into invalid-update

d6d6d70

JoshuaKGoldberg merged commit1a8e0dc intotypescript-eslint:main

Jan 4, 2024

Josh-Cena deleted the invalid-update branch

January 4, 2024 16:52

github-actionsbot locked asresolvedand limited conversation to collaborators

Jan 12, 2024

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

enhancement

New feature or request

4 participants

Movatterモバイル変換

Uh oh!

feat(typescript-estree): throw on invalid update expressions#7202

feat(typescript-estree): throw on invalid update expressions#7202

Uh oh!

Conversation

Josh-Cena commentedJul 12, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJul 12, 2023

Uh oh!

netlifybot commentedJul 12, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedJul 12, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

bradzacher commentedJul 17, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

Josh-Cena commentedJul 18, 2023

Uh oh!

Uh oh!

fisker commentedJul 23, 2023

Uh oh!

bradzacher commentedJul 23, 2023

Uh oh!

fisker commentedJul 28, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

bradzacherNov 10, 2023

Choose a reason for hiding this comment

Uh oh!

Josh-CenaNov 23, 2023

Choose a reason for hiding this comment

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Josh-Cena commentedJul 12, 2023•
edited
Loading

netlifybot commentedJul 12, 2023•
edited
Loading

nx-cloudbot commentedJul 12, 2023•
edited
Loading

bradzacher commentedJul 17, 2023•
edited
Loading

fisker commentedJul 28, 2023•
edited
Loading