Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [prefer-includes] escape special characters#7161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromMax10240:main
Jul 8, 2023

Conversation

@Max10240
Copy link
Contributor

PR Checklist

Overview

omril1 reacted with rocket emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Max10240!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJul 2, 2023•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

NameLink
🔨 Latest commit305a166
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/64a8f04b8bbb600008bb3fc8

@nx-cloud
Copy link

nx-cloudbot commentedJul 2, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit305a166. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedJul 2, 2023•
edited
Loading

Codecov Report

Merging#7161 (af33cb7) intomain (2f46341) willincrease coverage by0.00%.
The diff coverage is87.50%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #7161   +/-   ##=======================================  Coverage   87.39%   87.40%           =======================================  Files         386      386             Lines       13198    13203    +5       Branches     3873     3872    -1     =======================================+ Hits        11535    11540    +5  Misses       1296     1296             Partials      367      367
FlagCoverage Δ
unittest87.40% <87.50%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ackages/eslint-plugin/src/rules/prefer-includes.ts97.84% <87.50%> (+0.12%)⬆️

@Max10240Max10240 changed the titlefix: escape special characters #7145fix(eslint-plugin): [prefer-includes] escape special characters #7145Jul 5, 2023
`,
errors:[{messageId:'preferStringIncludes'}],
},
// test SequenceExpression
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldbergJul 8, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Non-actionable / Praise] More and more do I wish JavaScript just didn't have SequenceExpression 🙃 it's so confusing... +1 to you for explicitly adding tests for it.

Max10240 reacted with laugh emoji
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix(eslint-plugin): [prefer-includes] escape special characters #7145fix(eslint-plugin): [prefer-includes] escape special charactersJul 8, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🔥 this is great, thanks@Max10240!

I'm going to add one quick little test for the issue's repro case, then merge. 👍

Max10240 reacted with heart emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commit5a347a5 intotypescript-eslint:mainJul 8, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [prefer-includes] Autofix does not escape special characters

2 participants

@Max10240@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp