typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

chore: bump to latest lerna and apply custom release entry markdown#7139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JamesHenry merged 2 commits intomainfromchangelog-entry-markdown

Jun 25, 2023

Merged

chore: bump to latest lerna and apply custom release entry markdown#7139

JamesHenry merged 2 commits intomainfromchangelog-entry-markdown

Jun 25, 2023

Conversation

Copy link

Member

JamesHenry commentedJun 25, 2023

No description provided.

chore: bump to latest lerna and apply custom release entry markdown

0e8812c

Copy link

Contributor

typescript-eslintbot commentedJun 25, 2023

Thanks for the PR,@JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

JamesHenry requested a review frombradzacher

June 25, 2023 10:02

Copy link

netlifybot commentedJun 25, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`add69b0`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64982377da50a000089c8db4
😎 Deploy Preview	https://deploy-preview-7139--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

JamesHenry commented

Jun 25, 2023

View reviewed changes

nx.json

		@@ -1,6 +1,5 @@
		{
		"$schema":"./node_modules/nx/schemas/nx-schema.json",
		"npmScope":"typescript-eslint",

Copy link

MemberAuthor

JamesHenryJun 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is deprecated and no longer really used in nx, it will derive it from your existing root package

JamesHenry commented

Jun 25, 2023

View reviewed changes

lerna.json

		@@ -1,5 +1,11 @@
		{
		"$schema":"node_modules/lerna/schemas/lerna-schema.json",

Copy link

MemberAuthor

JamesHenryJun 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We added this a while ago, always nice to get IDE autocomplete etc

Copy link

nx-cloudbot commentedJun 25, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitadd69b0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets