Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(utils): RuleTester should not require a parser#713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 1 commit intotypescript-eslint:masterfromSimenB:optional-parser
Jul 17, 2019
Merged

fix(utils): RuleTester should not require a parser#713

bradzacher merged 1 commit intotypescript-eslint:masterfromSimenB:optional-parser
Jul 17, 2019

Conversation

SimenB
Copy link
Contributor

As briefly discussed in#425.

Background is that I want to use these utils for authoring eslint rules, but I want the tests to run using the default parser as the rules do not need type info

@@ -46,7 +46,12 @@ interface RunTests<
invalid: InvalidTestCase<TMessageIds, TOptions>[];
}
interface RuleTesterConfig {
parser: '@typescript-eslint/parser';
parser?:
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These are the ones listed here:https://eslint.org/docs/user-guide/configuring#specifying-parser

addedstring as well in case there are others

@bradzacher
Copy link
Member

unfortunately eslint v6 introduced a breaking change with the rule tester which requires that the parser berequire.resolve('parser').

I discovered it whilst adding v6 support, so this has been handled as part of#645

specific line:https://github.com/typescript-eslint/typescript-eslint/pull/645/files#diff-9d24728f5005799a507ba4b6eba78863R50

We'll be looking at doing the breaking 2.0.0 release soon!

SimenB reacted with thumbs up emoji

@SimenB
Copy link
ContributorAuthor

Can this land in the meantime? It's valid for eslint 5. Or just make it a string and skip the specific parser listings in v1 as well?

We'll be looking at doing the breaking 2.0.0 release soon!

Of course, if there'll be no more v1 releases it's not worth it to change 🙂

@bradzacher
Copy link
Member

James and I need to coordinate some time, so it might be another week or so.
I guess this is fine to merge into master. Even if we don't do another 1.x release, it'll be up in the canary release at the very least.

SimenB reacted with hooray emoji

@SimenB
Copy link
ContributorAuthor

Ah right, you release canaries from master! That's such an awesome feature of this repo. We really should get that going for Jest as well...

@bradzacher
Copy link
Member

yup! every commit to master is automatically pushed to thecanary tag on npm.
Keeps people happy when we lag behind on thelatest tag releases 😛

SimenB reacted with thumbs up emoji

@bradzacherbradzacher added the bugSomething isn't working labelJul 17, 2019
@bradzacherbradzacher merged commit158a417 intotypescript-eslint:masterJul 17, 2019
@SimenBSimenB deleted the optional-parser branchJuly 18, 2019 05:45
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
bugSomething isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SimenB@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp