Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [ban-types] ban types in extends and implements#7129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Haberkamp
Copy link
Contributor

PR Checklist

Overview

This PR will make sure that banned types are not able to be extended from or being used by classes for implementing a banned interface.

interfaceFoo{}interfaceBarextendsFoo{}// will fail nowclassBazimplementsFoo{}// will also fail now

The updated rule will also work with interfaces that extend from multiple interfaces like this one:

// banned interfaceinterface Foo {}// allowed interfaceinterface Bar {}interface Baz extends Bar, Foo {} // will fail because Baz extends from banned type Foo

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Haberkamp!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJun 22, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit9f6dfa8
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/649be0722298490008b58848
😎 Deploy Previewhttps://deploy-preview-7129--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedJun 22, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit9f6dfa8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

@HaberkampHaberkamp changed the titleBan certain types to be extended fromfeat(eslint-plugin): ban certain types to be extended fromJun 22, 2023
@HaberkampHaberkamp marked this pull request as ready for reviewJune 22, 2023 09:54
@codecov
Copy link

codecovbot commentedJun 22, 2023•
edited
Loading

Codecov Report

Merging#7129 (9f6dfa8) intomain (faea3ff) willincrease coverage by0.00%.
The diff coverage is100.00%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #7129   +/-   ##=======================================  Coverage   87.43%   87.43%           =======================================  Files         386      386             Lines       13192    13194    +2       Branches     3872     3872           =======================================+ Hits        11534    11536    +2  Misses       1292     1292             Partials      366      366
FlagCoverage Δ
unittest87.43% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
packages/eslint-plugin/src/rules/ban-types.ts100.00% <100.00%> (ø)

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯, excellent first contribution. Thanks!

Jon Snow from Game of Thrones doing a cute hair flip. Caption: flawless

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat(eslint-plugin): ban certain types to be extended fromfeat(eslint-plugin): [ban-types] ban types in extends and implementsJun 28, 2023
@JoshuaKGoldbergJoshuaKGoldberg merged commit997783f intotypescript-eslint:mainJun 28, 2023
json-derulo referenced this pull request in json-derulo/angular-ecmascript-intlJul 4, 2023
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---||[@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint)| devDependencies | minor | [`5.60.1` ->`5.61.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.60.1/5.61.0)||[@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint)| devDependencies | minor | [`5.60.1` ->`5.61.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.60.1/5.61.0)|---### Release Notes<details><summary>typescript-eslint/typescript-eslint(@&#8203;typescript-eslint/eslint-plugin)</summary>###[`v5.61.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5610-2023-07-03)[CompareSource](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.60.1...v5.61.0)##### Features- **eslint-plugin:** \[ban-types] ban types in extends and implements(#&#8203[https://github.com/typescript-eslint/typescript-eslint/issues/7129](https://togithub.com/typescript-eslint/typescript-eslint/issues/7129)es/7129))([997783f](https://togithub.com/typescript-eslint/typescript-eslint/commit/997783ff108ca18af709667ef3fdfa7134a8eefe))- use graphemer instead of grapheme-splitter(#&#8203;[https://github.com/typescript-eslint/typescript-eslint/issues/7069](https://togithub.com/typescript-eslint/typescript-eslint/issues/7069)s/7069))([faea3ff](https://togithub.com/typescript-eslint/typescript-eslint/commit/faea3ff8b4d750974c41262b44db314f20d0c99c))You can read about our [versioningstrategy](https://main--typescript-eslint.netlify.app/users/versioning)and[releases](https://main--typescript-eslint.netlify.app/users/releases)on our website.####[5.60.1](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.60.0...v5.60.1)(2023-06-26)**Note:** Version bump only for package[@&#8203;typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin)You can read about our [versioningstrategy](https://main--typescript-eslint.netlify.app/users/versioning)and[releases](https://main--typescript-eslint.netlify.app/users/releases)on our website.</details><details><summary>typescript-eslint/typescript-eslint(@&#8203;typescript-eslint/parser)</summary>###[`v5.61.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5610-2023-07-03)[CompareSource](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.60.1...v5.61.0)**Note:** Version bump only for package[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)You can read about our [versioningstrategy](https://main--typescript-eslint.netlify.app/users/versioning)and[releases](https://main--typescript-eslint.netlify.app/users/releases)on our website.####[5.60.1](https://togithub.com/typescript-eslint/typescript-eslint/compare/v5.60.0...v5.60.1)(2023-06-26)**Note:** Version bump only for package[@&#8203;typescript-eslint/parser](https://togithub.com/typescript-eslint/parser)You can read about our [versioningstrategy](https://main--typescript-eslint.netlify.app/users/versioning)and[releases](https://main--typescript-eslint.netlify.app/users/releases)on our website.</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about theseupdates again.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [RenovateBot](https://togithub.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNTkuMyIsInVwZGF0ZWRJblZlciI6IjM1LjE1OS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->Co-authored-by: Renovate Bot <bot@renovateapp.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 6, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: [ban-types] ban certain types to be extended from

2 participants

@Haberkamp@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp