feat(typescript-estree): remove parseWithNodeMaps#7120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v6fromJoshuaKGoldberg:remove-parse-with-node-maps

Jun 24, 2023

Merged

feat(typescript-estree): remove parseWithNodeMaps#7120

JoshuaKGoldberg merged 1 commit intotypescript-eslint:v6fromJoshuaKGoldberg:remove-parse-with-node-maps

Jun 24, 2023

Conversation

Copy link

Member

JoshuaKGoldberg commentedJun 20, 2023

PR Checklist

Addresses an existing open issue:fixesRemove parseWithNodeMaps #7119
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Removes the exportedparseWithNodeMaps & associated testing.

feat(typescript-estree): remove parseWithNodeMaps

e1aabd0

Copy link

Contributor

typescript-eslintbot commentedJun 20, 2023

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJun 20, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`e1aabd0`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/649129cc742c3e000835e4c0
😎 Deploy Preview	https://deploy-preview-7120--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

nx-cloudbot commentedJun 20, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite1aabd0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedJun 20, 2023

Codecov Report

Merging#7120 (e1aabd0) intov6 (b411706) willdecrease coverage by0.08%.
The diff coverage isn/a.

Additional details and impacted files

@@            Coverage Diff             @@##               v6    #7120      +/-   ##==========================================- Coverage   87.50%   87.43%   -0.08%==========================================  Files         372      372                Lines       12849    12849                Branches     3813     3813              ==========================================- Hits        11244    11235       -9- Misses       1227     1237      +10+ Partials      378      377       -1