Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

❌ Deploy Preview fortypescript-eslint failed.

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3a01637. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Sent with 💌 fromNxCloud.

Run ./.github/actions/wait-for-netlify/home/runner/work/typescript-eslint/typescript-eslint/node_modules/@actions/core/lib/core.js:106        throw new Error(`Input required and not supplied: ${name}`);        ^Error: Input required and not supplied: netlify_token

@JamesHenry something funky with the new action, perhaps?https://github.com/typescript-eslint/typescript-eslint/actions/runs/5195237524/jobs/9367800550?pr=7088

PASS  tests/lib/node-utils.test.ts PASS  tests/lib/parse.project-true.test.ts<--- Last few GCs --->[2972:0x61b15c0]   201164 ms: Mark-sweep (reduce) 2037.5 (2051.0) -> 2036.7 (2052.5) MB, 2662.2 / 0.0 ms  (average mu = 0.171, current mu = 0.014) allocation failure scavenge might not succeed[2972:0x61b15c0]   203868 ms: Mark-sweep (reduce) 2037.8 (2051.5) -> 2037.3 (2052.8) MB, [26](https://github.com/typescript-eslint/typescript-eslint/actions/runs/5195237524/jobs/9367799309?pr=7088#step:6:27)32.6 / 0.0 ms  (average mu = 0.102, current mu = 0.026) allocation failure scavenge might not succeed<--- JS stacktrace --->FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory 1: 0xa3ad50 node::Abort() [/opt/hostedtoolcache/node/14.21.3/x64/bin/node]

sigh.

Run ./.github/actions/wait-for-netlify/home/runner/work/typescript-eslint/typescript-eslint/node_modules/@actions/core/lib/core.js:106        throw new Error(`Input required and not supplied: ${name}`);        ^Error: Input required and not supplied: netlify_token

@JamesHenry something funky with the new action, perhaps?https://github.com/typescript-eslint/typescript-eslint/actions/runs/5195237524/jobs/9367800550?pr=7088

Oh sorry, I reckon it could be that the secret doesn’t work as an input when you’re coming from a fork…

I will figure out how this has been workable for other actions in the past

@JoshuaKGoldberg@bradzacher I can't find any evidence that this ever worked. I think the secret won't be populated on forks which makes sense.

I have therefore just pushed a commit to the branch which should should hopefully amend things to only run the Website Tests when not on a fork

I thought that should work based on this answer:https://github.com/orgs/community/discussions/26409#discussioncomment-3251822

anyone know the right syntax here?

That's all we've got here:

IDK why it wouldn't be working there?

@JoshuaKGoldberg once you've got all the tests passing locally feel free to just land this to main.

We can follow up with a fix commit if any CIs fail on main.

Ah, this may be from adifferent TypeScript issue likely to be fixed soon:microsoft/TypeScript#54542

Codecov Report

Merging#7088 (3a01637) intomain (f74862c) willdecrease coverage by0.04%.
The diff coverage is33.33%.

@@            Coverage Diff             @@##             main    #7088      +/-   ##==========================================- Coverage   87.43%   87.39%   -0.04%==========================================  Files         386      386                Lines       13192    13198       +6       Branches     3872     3873       +1     ==========================================+ Hits        11534    11535       +1- Misses       1292     1296       +4- Partials      366      367       +1