Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
docs: reorganise release/version docs#7033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedMay 17, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site settings. |
nx-cloudbot commentedMay 17, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Incomplete reviews. Can we also settle on a file naming convention? We seem to be using more kebab-casing (and some SCREAM_CASING) in the past.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The convention in I have no preference one way or the other though. (If it were up to me I'd use |
bradzacher commentedMay 17, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Build error Weirdly it didn't show up locally using @Josh-Cena there were a number of times that I moved files around and then ran |
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
| 'users/releases', | ||
| 'users/versioning', | ||
| ], | ||
| label:'Users', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is the only part of this PR I'm not 100% positive on... Everybody is a user. Is there a more precise term we can use?End Users perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My thinking was there are "users" which are the ones doing linting and the "developers" which are the ones building things with their tooling.
Technically the "developers" are "users" of our tooling, for sure, but I thought there might be enough distinction?
I don't love "end users"... I wonder if there's another term we can use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, the broken link detection only works reliably in build. Sometimes dev also reports link errors but I can't remember in which cases (usually when it blocks rendering the correct link) |

Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
v5.59.6? #7031Overview
Slight cleanup / reorganisation / deduplication of the docs here
To start with - the new sidebar:
Sidebar Changes:
You can follow the changes but I moved some sections around amongst the "User" docs to deduplicate. EG I noticed there wasn't really clear delineation between the "releases" doc and the "versioning" doc - and there was some duplication between them too.
@JamesHenry - is there any way to add a custom footer to the GH release notes?
I'd love it if we could add a link to both the "Releases" and "Versioning" pages to the release notes so that we can very clearly promote these docs.