Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: enable sort-type-constituents internally#7028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Enablessort-type-constituents internally. This one rule has a lot of reports, so I wanted to get them out of the way before continuing with other to-be-newly-enabled rules.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMay 13, 2023
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitea3845a
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6497337118340d0008fdd5cb
😎 Deploy Previewhttps://deploy-preview-7028--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@JoshuaKGoldbergJoshuaKGoldberg changed the base branch frommain tov6May 13, 2023 02:03
@JoshuaKGoldbergJoshuaKGoldberg changed the titleEnable internal sort type constituentschore: enable sort-type-constituents internallyMay 13, 2023
@nx-cloud
Copy link

nx-cloudbot commentedMay 13, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitea3845a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 26 targets

Sent with 💌 fromNxCloud.

@codecov
Copy link

codecovbot commentedMay 13, 2023
edited
Loading

Codecov Report

Merging#7028 (ea3845a) intov6 (e2a0a76) willnot change coverage.
The diff coverage is100.00%.

Additional details and impacted files
@@           Coverage Diff           @@##               v6    #7028   +/-   ##=======================================  Coverage   87.43%   87.43%           =======================================  Files         372      372             Lines       12849    12849             Branches     3813     3813           =======================================  Hits        11235    11235             Misses       1237     1237             Partials      377      377
FlagCoverage Δ
unittest87.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...lugin-internal/src/rules/plugin-test-formatting.ts79.76% <ø> (ø)
packages/eslint-plugin-tslint/src/rules/config.ts97.72% <ø> (ø)
...t-plugin/src/rules/adjacent-overload-signatures.ts95.34% <ø> (ø)
packages/eslint-plugin/src/rules/array-type.ts97.14% <ø> (ø)
packages/eslint-plugin/src/rules/ban-ts-comment.ts96.96% <ø> (ø)
...ages/eslint-plugin/src/rules/ban-tslint-comment.ts100.00% <ø> (ø)
packages/eslint-plugin/src/rules/ban-types.ts100.00% <ø> (ø)
packages/eslint-plugin/src/rules/brace-style.ts95.34% <ø> (ø)
...t-plugin/src/rules/class-literal-property-style.ts100.00% <ø> (ø)
packages/eslint-plugin/src/rules/comma-spacing.ts100.00% <ø> (ø)
... and94 more

@bradzacherbradzacher added 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge repo maintenancethings to do with maintenance of the repo, and not with code/docs labelsJun 24, 2023
@JoshuaKGoldbergJoshuaKGoldberg merged commit3cdf5c9 intotypescript-eslint:v6Jun 24, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the enable-internal-sort-type-constituents branchJune 24, 2023 19:48
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJul 2, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergerepo maintenancethings to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp