Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-extra-parens] false positive when used withsatisfies keyword#7026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

fcorsair
Copy link

PR Checklist

Overview

Added new condition insideMemberExpression type rule forSatisfiesExpression node type, added new simple test.

This is my first PR, be kind 😄 ❤️

JoshuaKGoldberg reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@fcorsair!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMay 12, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitbe84387
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/645ecd220687e60008c3a4b6
😎 Deploy Previewhttps://deploy-preview-7026--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@fcorsairfcorsair changed the titlefix(eslin-plugin): [no-extra-parens] false positive when used withsatisfies keywordfix(eslint-plugin): [no-extra-parens] false positive when used withsatisfies keywordMay 12, 2023
@nx-cloud
Copy link

nx-cloudbot commentedMay 12, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitbe84387. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A good start, thanks for sending this in! 🙌

Requesting changes for increased test coverage. This stuff can get tricky! I'd suggest seeing the discussion in#6885 to check if there's some shared logic that should be updated. I can review more deeply once there are more test cases.

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelMay 12, 2023
@codecov
Copy link

codecovbot commentedMay 12, 2023

Codecov Report

Merging#7026 (be84387) intomain (a6f23a2) willincrease coverage by0.00%.
The diff coverage is100.00%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #7026   +/-   ##=======================================  Coverage   87.38%   87.38%           =======================================  Files         386      386             Lines       13193    13195    +2       Branches     3867     3868    +1     =======================================+ Hits        11529    11531    +2  Misses       1298     1298             Partials      366      366
FlagCoverage Δ
unittest87.38% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
...ackages/eslint-plugin/src/rules/no-extra-parens.ts91.66% <100.00%> (+0.20%)⬆️

@xsjcTony

This comment was marked as spam.

@bradzacherbradzacher added the bugSomething isn't working labelJul 17, 2023
@@ -242,6 +242,11 @@ f<(number | string)[]>(['a', 1])
},
},
}),
{
code: `
const a = (['a', 'b'] satisfies A[]).includes('a');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Recreating a new thread fromhttps://github.com/typescript-eslint/typescript-eslint/pull/7026/files#r1192868544: shouldn't this still cause a rule report?

consta=((['a','b']satisfiesA[])).includes('a');

Note the extra parenthesis around the(['a', 'b'] satisfies A[]).

fcorsair reacted with thumbs up emoji
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sure, this case definitely deserves a test

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry if I was unclear on this one - the code looks nice in general, but I think there's a missing test case that fails locally for me?

fcorsair reacted with thumbs up emoji
@JoshuaKGoldberg
Copy link
Member

Ping@fcorsair, is this still something you have time & interest for?

@fcorsair
Copy link
Author

Ping@fcorsair, is this still something you have time & interest for?

yes, I would like to complete this PR, I've been a little busy in the last months

@JoshuaKGoldberg
Copy link
Member

Closing this PR as it's been stale for ~6 weeks without activity. Feel free to reopen@fcorsair if you have time - but no worries if not! If anybody wants to drive it forward, please do post your own PR - and if you use this as a start, consider addingCo-authored-by: @fcorsair at the end of your PR description. Thanks! 😊

@JoshuaKGoldbergJoshuaKGoldberg added the stalePRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period labelOct 18, 2023
@fcorsair
Copy link
Author

fcorsair commentedOct 18, 2023•
edited
Loading

Hi@JoshuaKGoldberg I don’t get from the issuediscussion if the problem should be now fixed from latest eslint versions or still not. Do you confirm it?

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commentedOct 19, 2023•
edited
Loading

I'm not sure what you mean, but if there's a bug in typescript-eslint with an equivalent that was fixed in ESLint core we can always take an issue.

@fcorsair
Copy link
Author

fcorsair commentedOct 19, 2023•
edited
Loading

I'm not sure what you mean, but if there's a bug in typescript-eslint with an equivalent that was fixed in ESLint core we can always take an issue.

Ok now I get it, it’s fixed in eslint only, still bugged in ts-eslint

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg requested changes

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another partybugSomething isn't workingstalePRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-extra-parens] False positive when used withsatisfies keyword
4 participants
@fcorsair@xsjcTony@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp