Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): add new rule restrict-plus-operands#70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 9 commits intotypescript-eslint:masterfromarmano2:restrict-plus-operands
Jan 22, 2019
Merged

feat(eslint-plugin): add new rule restrict-plus-operands#70

JamesHenry merged 9 commits intotypescript-eslint:masterfromarmano2:restrict-plus-operands
Jan 22, 2019

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedJan 18, 2019•
edited
Loading

This PR implement rulerestrict-plus-operands

  • implement rule
  • add tests
  • add documentation

continuation ofbradzacher/eslint-plugin-typescript#230

@armano2armano2 added the DO NOT MERGEPRs which should not be merged yet labelJan 18, 2019
@bradzacher
Copy link
Member

(shouldn't this be a feat?)

@armano2armano2 changed the titlefix(plugin-typescript): Add rule restrict-plus-operandsfeat(plugin-typescript): Add rule restrict-plus-operandsJan 18, 2019
@armano2
Copy link
CollaboratorAuthor

armano2 commentedJan 18, 2019•
edited
Loading

it should

i have some concerns about performance for now, i will have to digg in a little to check if this is not related to ts-estree

@armano2armano2 self-assigned thisJan 19, 2019
@JamesHenry
Copy link
Member

I think looking to land this after the first release would be best 👍

armano2 reacted with thumbs up emoji

@armano2armano2 changed the titlefeat(plugin-typescript): Add rule restrict-plus-operandsfeat(eslint-plugin): add new rule restrict-plus-operandsJan 20, 2019
@armano2armano2 added enhancement: new plugin ruleNew rule request for eslint-plugin and removed DO NOT MERGEPRs which should not be merged yet labelsJan 20, 2019
Copy link
Member

@JamesHenryJamesHenry left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Now that v1 is out the door we can consider merging this.

@armano2 Can you elaborate on the performance concerns, and what has changed since you first opened the PR?

@armano2
Copy link
CollaboratorAuthor

armano2 commentedJan 21, 2019•
edited
Loading

i did profiling on this rule, and there is no performance impact generated by our code, TypeCheker is not fast, and most likely there is some room to improve it ints-estree, but i didn't found any direct issue in this rule

@JamesHenry
Copy link
Member

Ok great, thanks

@codecov
Copy link

codecovbot commentedJan 22, 2019

Codecov Report

Merging#70 intomaster willincrease coverage by0.12%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master      #70      +/-   ##==========================================+ Coverage   95.01%   95.14%   +0.12%==========================================  Files          48       49       +1       Lines        2487     2512      +25       Branches      382      382              ==========================================+ Hits         2363     2390      +27+ Misses         75       73       -2  Partials       49       49
Impacted FilesCoverage Δ
.../eslint-plugin/lib/rules/restrict-plus-operands.js100% <100%> (ø)
packages/eslint-plugin/lib/util.js97.22% <0%> (+5.55%)⬆️

@JamesHenryJamesHenry merged commitc541ede intotypescript-eslint:masterJan 22, 2019
@armano2armano2 deleted the restrict-plus-operands branchJanuary 22, 2019 17:13
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@j-f1j-f1j-f1 left review comments

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees

@armano2armano2

Labels
enhancement: new plugin ruleNew rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@armano2@bradzacher@JamesHenry@j-f1
[8]ページ先頭
©2009-2025 Movatter.jp