Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(typescript-estree): enable error codes TS1085 and TS8017 for legacy octal literals#7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 5 commits intotypescript-eslint:masterfromarmano2:legacy-octal
Jan 16, 2019

Conversation

@armano2
Copy link
Collaborator

This PR adds test cases for numeric values, and fixes issue with legacy octal number in non strict mode.

j-f1 reacted with thumbs up emoji
@codecov
Copy link

codecovbot commentedJan 14, 2019•
edited
Loading

Codecov Report

Merging#7 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master       #7   +/-   ##=======================================  Coverage   93.77%   93.77%           =======================================  Files          11       11             Lines        1686     1686             Branches      376      376           =======================================  Hits         1581     1581             Misses         55       55             Partials       50       50
Impacted FilesCoverage Δ
packages/typescript-estree/src/semantic-errors.ts77.77% <ø> (ø)⬆️
packages/typescript-estree/src/convert.ts94.46% <ø> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update0fbeca8...1faf80f. Read thecomment docs.

@armano2
Copy link
CollaboratorAuthor

i'm starting to think, that it will be better if typescript itself will support this, instead of making us do special case fo it

@JamesHenry
Copy link
Member

@uniqueiniquity What are you thoughts on this?

@armano2armano2 changed the titlefix(estree): fix parsing legacy octal number value and add testsfix(typescript-estree): fix parsing legacy octal number value and add testsJan 16, 2019
@sandersn
Copy link
Contributor

@uniqueiniquity and I looked over the history of number parsing in Typescript and it looks like it's never really supported octal literals.077 was always parsed to have the value 77. This wasn't even aproblem for us inside the compiler until literal types were introduced. And the way we resolved the problem was not to support old-style octal syntax, but to put an error saying that the standard form was required. So I don't think we'll add correct support for old-style octal syntax in the value space either.

Out of curiosity, why does typescript-eslint need to support this syntax?

@armano2
Copy link
CollaboratorAuthor

armano2 commentedJan 16, 2019•
edited
Loading

we don't have to, i just found issue in alignment tests with babel/estree.
@JamesHenry should we enable TS1085 and TS8017 instead?

@JamesHenry
Copy link
Member

Yeah sounds good,@armano2

Thanks for sharing the background@sandersn!

armano2 reacted with thumbs up emoji

@armano2armano2 changed the titlefix(typescript-estree): fix parsing legacy octal number value and add testsfix(typescript-estree): enable errors about legacy octal literalsJan 16, 2019
@armano2armano2 changed the titlefix(typescript-estree): enable errors about legacy octal literalsfix(typescript-estree): enable error codes TS1085 and TS8017 for legacy octal literalsJan 16, 2019
@JamesHenryJamesHenry merged commitfb1b12b intotypescript-eslint:masterJan 16, 2019
@armano2armano2 deleted the legacy-octal branchJanuary 16, 2019 21:03
JamesHenry pushed a commit that referenced this pull requestJan 17, 2019
## 2.2.0 (2018-08-25)* ci: Added missing packages ([3938da6](unlight/eslint-plugin-tslint2@3938da6))* ci(.travis.yml): Add greenkeeper-lockfile support (#7) ([706d9d6](unlight/eslint-plugin-tslint2@706d9d6)), closes [#7](https://github.com/unlight/eslint-plugin-tslint2/issues/7)* Merge branch 'dev' ([db9bf0e](unlight/eslint-plugin-tslint2@db9bf0e))* docs: Updated README ([b6947be](unlight/eslint-plugin-tslint2@b6947be))* chore: Disabled package-lock ([07fa1d6](unlight/eslint-plugin-tslint2@07fa1d6))* chore: Removed old infrastructure code ([43f5b4e](unlight/eslint-plugin-tslint2@43f5b4e))* chore(package): Update @types/node to version 8.0.54 ([06c9397](unlight/eslint-plugin-tslint2@06c9397))* chore(package): Update @types/node to version 8.0.57 (#18) ([719dc89](unlight/eslint-plugin-tslint2@719dc89)), closes [#18](https://github.com/unlight/eslint-plugin-tslint2/issues/18)* chore(package): Update @types/node to version 8.0.58 (#20) ([a1ed18f](unlight/eslint-plugin-tslint2@a1ed18f)), closes [#20](https://github.com/unlight/eslint-plugin-tslint2/issues/20)* chore(package): Update eslint to version 4.12.0 (#8) ([041551c](unlight/eslint-plugin-tslint2@041551c)), closes [#8](https://github.com/unlight/eslint-plugin-tslint2/issues/8)* chore(package): Update eslint to version 4.12.1 (#11) ([5124913](unlight/eslint-plugin-tslint2@5124913)), closes [#11](https://github.com/unlight/eslint-plugin-tslint2/issues/11)* chore(package): Update eslint to version 4.13.0 (#17) ([2695502](unlight/eslint-plugin-tslint2@2695502)), closes [#17](https://github.com/unlight/eslint-plugin-tslint2/issues/17)* chore(package): update eslint to version 4.13.1 ([7f1b4fa](unlight/eslint-plugin-tslint2@7f1b4fa))* chore(package): Update lint-staged to to version 6.0.0 (#12) ([040ec25](unlight/eslint-plugin-tslint2@040ec25)), closes [#12](https://github.com/unlight/eslint-plugin-tslint2/issues/12)* chore(package): Update prettier-eslint-cli to version 4.4.2 ([2d024f3](unlight/eslint-plugin-tslint2@2d024f3)), closes [#13](https://github.com/unlight/eslint-plugin-tslint2/issues/13)* chore(package): Update typescript to to version 2.6.2 (#9) ([25661af](unlight/eslint-plugin-tslint2@25661af)), closes [#9](https://github.com/unlight/eslint-plugin-tslint2/issues/9)* chore(package): Update typescript-eslint-parser to version 10.0.0 (#19) ([4b9230b](unlight/eslint-plugin-tslint2@4b9230b)), closes [#19](https://github.com/unlight/eslint-plugin-tslint2/issues/19)* chore(package): Update typescript-eslint-parser to version 9.0.1 (#10) ([a39256c](unlight/eslint-plugin-tslint2@a39256c)), closes [#10](https://github.com/unlight/eslint-plugin-tslint2/issues/10)* chore(README): Banner URL ([d0ac4d2](unlight/eslint-plugin-tslint2@d0ac4d2))* chore(travis): Whitelist greenkeeper branches (#6) ([4cc915b](unlight/eslint-plugin-tslint2@4cc915b)), closes [#6](https://github.com/unlight/eslint-plugin-tslint2/issues/6)* refactor: Rewritten always-fail-rule in es2015 style ([651b629](unlight/eslint-plugin-tslint2@651b629))* style: Changed indent to 4 spaces ([bfa7756](unlight/eslint-plugin-tslint2@bfa7756))* feat(core): Added support rules requires type information ([6bc1deb](unlight/eslint-plugin-tslint2@6bc1deb)), closes [#32](https://github.com/unlight/eslint-plugin-tslint2/issues/32) [#34](https://github.com/unlight/eslint-plugin-tslint2/issues/34)
JamesHenry pushed a commit that referenced this pull requestJan 17, 2019
## 2.2.0 (2018-08-25)* ci: Added missing packages ([3938da6](unlight/eslint-plugin-tslint2@3938da6))* ci(.travis.yml): Add greenkeeper-lockfile support (#7) ([706d9d6](unlight/eslint-plugin-tslint2@706d9d6)), closes [#7](https://github.com/unlight/eslint-plugin-tslint2/issues/7)* Merge branch 'dev' ([db9bf0e](unlight/eslint-plugin-tslint2@db9bf0e))* docs: Updated README ([b6947be](unlight/eslint-plugin-tslint2@b6947be))* chore: Disabled package-lock ([07fa1d6](unlight/eslint-plugin-tslint2@07fa1d6))* chore: Removed old infrastructure code ([43f5b4e](unlight/eslint-plugin-tslint2@43f5b4e))* chore(package): Update @types/node to version 8.0.54 ([06c9397](unlight/eslint-plugin-tslint2@06c9397))* chore(package): Update @types/node to version 8.0.57 (#18) ([719dc89](unlight/eslint-plugin-tslint2@719dc89)), closes [#18](https://github.com/unlight/eslint-plugin-tslint2/issues/18)* chore(package): Update @types/node to version 8.0.58 (#20) ([a1ed18f](unlight/eslint-plugin-tslint2@a1ed18f)), closes [#20](https://github.com/unlight/eslint-plugin-tslint2/issues/20)* chore(package): Update eslint to version 4.12.0 (#8) ([041551c](unlight/eslint-plugin-tslint2@041551c)), closes [#8](https://github.com/unlight/eslint-plugin-tslint2/issues/8)* chore(package): Update eslint to version 4.12.1 (#11) ([5124913](unlight/eslint-plugin-tslint2@5124913)), closes [#11](https://github.com/unlight/eslint-plugin-tslint2/issues/11)* chore(package): Update eslint to version 4.13.0 (#17) ([2695502](unlight/eslint-plugin-tslint2@2695502)), closes [#17](https://github.com/unlight/eslint-plugin-tslint2/issues/17)* chore(package): update eslint to version 4.13.1 ([7f1b4fa](unlight/eslint-plugin-tslint2@7f1b4fa))* chore(package): Update lint-staged to to version 6.0.0 (#12) ([040ec25](unlight/eslint-plugin-tslint2@040ec25)), closes [#12](https://github.com/unlight/eslint-plugin-tslint2/issues/12)* chore(package): Update prettier-eslint-cli to version 4.4.2 ([2d024f3](unlight/eslint-plugin-tslint2@2d024f3)), closes [#13](https://github.com/unlight/eslint-plugin-tslint2/issues/13)* chore(package): Update typescript to to version 2.6.2 (#9) ([25661af](unlight/eslint-plugin-tslint2@25661af)), closes [#9](https://github.com/unlight/eslint-plugin-tslint2/issues/9)* chore(package): Update typescript-eslint-parser to version 10.0.0 (#19) ([4b9230b](unlight/eslint-plugin-tslint2@4b9230b)), closes [#19](https://github.com/unlight/eslint-plugin-tslint2/issues/19)* chore(package): Update typescript-eslint-parser to version 9.0.1 (#10) ([a39256c](unlight/eslint-plugin-tslint2@a39256c)), closes [#10](https://github.com/unlight/eslint-plugin-tslint2/issues/10)* chore(README): Banner URL ([d0ac4d2](unlight/eslint-plugin-tslint2@d0ac4d2))* chore(travis): Whitelist greenkeeper branches (#6) ([4cc915b](unlight/eslint-plugin-tslint2@4cc915b)), closes [#6](https://github.com/unlight/eslint-plugin-tslint2/issues/6)* refactor: Rewritten always-fail-rule in es2015 style ([651b629](unlight/eslint-plugin-tslint2@651b629))* style: Changed indent to 4 spaces ([bfa7756](unlight/eslint-plugin-tslint2@bfa7756))* feat(core): Added support rules requires type information ([6bc1deb](unlight/eslint-plugin-tslint2@6bc1deb)), closes [#32](https://github.com/unlight/eslint-plugin-tslint2/issues/32) [#34](https://github.com/unlight/eslint-plugin-tslint2/issues/34)
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@armano2@JamesHenry@sandersn
[8]ページ先頭
©2009-2025 Movatter.jp