Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: replace extend any with unknown for no-unnecessary-type-constra…#6976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

takanome-dev
Copy link
Contributor

PR Checklist

Overview

This pr replaces the default constraint forno-unnecessary-type-constraint fromany tounknown in the docs.

Note: I'm not really sure if I have to change all the any to unknown in the example block. I tried in the test file and they all failed 😓 I have added two more examples using unknown (only in the incorrect section).

Please do let me know if there are additional steps I need to take 🙏

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@takanome-dev!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedApr 30, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit2042a9f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/64738d7210e3760008b83234
😎 Deploy Previewhttps://deploy-preview-6976--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@nx-cloud
Copy link

nx-cloudbot commentedApr 30, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit2042a9f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry this took so long@takanome-dev, I'd meant to enthusiastically respond but it slipped by. Thanks for sending!

Mostly looks great - just one suggestion for the docs to make the phrasing more clear. Thoughts?

Heidi Gardner dressed in fashion in SNL's Weekend Update enthusiastically saying 'I love it!'

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelMay 28, 2023
takanome-devand others added2 commitsMay 28, 2023 17:18
…nt.mdCo-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@takanome-dev
Copy link
ContributorAuthor

Mostly looks great - just one suggestion for the docs to make the phrasing more clear. Thoughts?

Sounds good 👍 Thanks for taking the time reviewing this 🙂

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lady in red dress emphatically gesturing and saying 'flawless'

takanome-dev reacted with thumbs up emojitakanome-dev reacted with hooray emojitakanome-dev reacted with rocket emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commitf5d174d intotypescript-eslint:mainMay 31, 2023
@takanome-devtakanome-dev deleted the no-unnecessary-type-constraint-extending-unknown branchMay 31, 2023 10:50
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 8, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: no-unnecessary-type-constraint should mention extending unknown
2 participants
@takanome-dev@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp