typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

chore(website): correct issue with rule schema defs#6942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

armano2 merged 1 commit intov6fromchore/playground-rule-schema-error

Apr 21, 2023

Merged

chore(website): correct issue with rule schema defs#6942

armano2 merged 1 commit intov6fromchore/playground-rule-schema-error

Apr 21, 2023

Conversation

Copy link

Collaborator

armano2 commentedApr 20, 2023•
edited
Loading

PR Checklist

That issue was marked asaccepting prs
Steps inContributing were taken

Overview

while rewriting schema assign$defs if present in first array item to new item

this is a side effect fix for recent changes (#6899) done to rule schemas

chore(website): correct issue with rule schema defs

19c4ce6

armano2 added the website: playground label

Apr 20, 2023

Copy link

Contributor

typescript-eslintbot commentedApr 20, 2023

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 20, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`19c4ce6`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/644187729eeeec0008195909
😎 Deploy Preview	https://deploy-preview-6942--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

nx-cloudbot commentedApr 20, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit19c4ce6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedApr 20, 2023

Codecov Report

Merging#6942 (19c4ce6) intov6 (acc1a43) willdecrease coverage by0.01%.
The diff coverage isn/a.

Additional details and impacted files

@@            Coverage Diff             @@##               v6    #6942      +/-   ##==========================================- Coverage   87.51%   87.50%   -0.01%==========================================  Files         376      376                Lines       12944    12936       -8       Branches     3821     3820       -1     ==========================================- Hits        11328    11320       -8  Misses       1231     1231                Partials      385      385