@domdomegg's#6894 made me realise I'd incorrectly handled this case in the schema gen.
When it's missing/undefined it's the same as beingtrue - but I treated it asfalse

fix: correct handling of additionalProperties in object schemas

223624d

Co-authored-by: Adam Jones <domdomegg+git@gmail.com>

bradzacher added the bugSomething isn't working label

Apr 20, 2023

Copy link

Contributor

typescript-eslintbot commentedApr 20, 2023

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 20, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`223624d`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64412c047da6e100086cd0a6
😎 Deploy Preview	https://deploy-preview-6939--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

bradzacher mentioned this pull request

Apr 20, 2023

fix(eslint-plugin): fix schemas across several rules and add schema tests#6894

Closed

3 tasks

Copy link

nx-cloudbot commentedApr 20, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit223624d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 32 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedApr 20, 2023

Codecov Report

Merging#6939 (223624d) intov6 (acc1a43) willdecrease coverage by0.01%.
The diff coverage isn/a.

Additional details and impacted files

@@            Coverage Diff             @@##               v6    #6939      +/-   ##==========================================- Coverage   87.51%   87.50%   -0.01%==========================================  Files         376      376                Lines       12944    12936       -8       Branches     3821     3820       -1     ==========================================- Hits        11328    11320       -8  Misses       1231     1231                Partials      385      385

Flag	Coverage Δ
unittest	`87.50% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts	`97.14% <ø> (ø)`
packages/eslint-plugin/src/rules/ban-ts-comment.ts	`96.96% <ø> (ø)`
...plugin/src/rules/naming-convention-utils/schema.ts	`100.00% <ø> (ø)`
...ges/eslint-plugin/src/rules/no-misused-promises.ts	`97.47% <ø> (ø)`
...-plugin/src/rules/no-unnecessary-type-assertion.ts	`94.59% <ø> (ø)`
...int-plugin/src/rules/require-array-sort-compare.ts	`87.50% <ø> (ø)`
...-plugin/src/rules/restrict-template-expressions.ts	`100.00% <ø> (ø)`
.../eslint-plugin/src/rules/sort-type-constituents.ts	`90.38% <ø> (ø)`
packages/eslint-plugin/src/rules/typedef.ts	`96.00% <ø> (ø)`