typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(eslint-plugin): [comma-spacing] allow no space after trailing comma in objects and arrays#6938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromislandryu:fix/comma-spacing-conflict-with-array-bracket-spacing

Jul 8, 2023

Merged

fix(eslint-plugin): [comma-spacing] allow no space after trailing comma in objects and arrays#6938

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromislandryu:fix/comma-spacing-conflict-with-array-bracket-spacing

Jul 8, 2023

Conversation

Copy link

Contributor

islandryu commentedApr 20, 2023•
edited by JoshuaKGoldberg
Loading

PR Checklist

Addresses an existing open issue:fixesBug: [comma-spacing] conflicts with array-bracket-spacing #6874
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

The following cases are allowed to pass

constarr=[a,];constobj={'foo':'bar','baz':'qur',};

The following test case passed in eslint, but I wasn't sure if it should be compliant, so I put it on hold
eslint/eslint#16113

{code:'const arr = [1 , ];',options:[{before:true,after:false}]},{code:'const arr = [,2 , ];',options:[{before:true,after:false}]},{code:"const obj = {'foo':'bar' ,'baz':'qur' , };",options:[{before:true,after:false}],},

islandryu added2 commits

April 20, 2023 09:15

feat(eslint-plugin):[comma-spacing]allow no space after trailing comm…

25dfe74

…a in objects and arrays

feat(eslint-plugin):[comma-spacing]add test cases

9e4e9aa

Copy link

Contributor

typescript-eslintbot commentedApr 20, 2023

Thanks for the PR,@islandryu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 20, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`9e4e9aa`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6440a357a22a120008b4b0f5
😎 Deploy Preview	https://deploy-preview-6938--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

nx-cloudbot commentedApr 20, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit9e4e9aa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

islandryu changed the title~~feat(eslint-plugin):[comma-spacing]allow no space after trailing comma in objects and arrays~~fix(eslint-plugin): [comma-spacing]allow no space after trailing comma in objects and arrays

Apr 20, 2023

islandryu changed the title~~fix(eslint-plugin): [comma-spacing]allow no space after trailing comma in objects and arrays~~fix(eslint-plugin): [comma-spacing] allow no space after trailing comma in objects and arrays

Apr 20, 2023

Copy link

codecovbot commentedApr 20, 2023

Codecov Report

Merging#6938 (9e4e9aa) intomain (4f3750f) willincrease coverage by0.00%.
The diff coverage is100.00%.

Additional details and impacted files

@@           Coverage Diff           @@##             main    #6938   +/-   ##=======================================  Coverage   87.37%   87.37%           =======================================  Files         386      386             Lines       13192    13197    +5       Branches     3867     3869    +2     =======================================+ Hits        11526    11531    +5  Misses       1300     1300             Partials      366      366