Doesn't provide an explicit"here's the right way to do this!" because I don't think there is one 🥲. At least not unless ESLint configs eventually could be written in TypeScript!

Instead, adds an explicit caution note and bolsters the FAQ entry to explicitly handle the idea of a root-level.cjs/.js file and typed linting.

docs: flesh out tips for typed linting and .eslintrc.cjs

7f18904

Copy link

Contributor

typescript-eslintbot commentedApr 16, 2023

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 16, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`3de2d52`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/644a9a623b2cc300083ecfca
😎 Deploy Preview	https://deploy-preview-6919--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

JoshuaKGoldberg commented

Apr 16, 2023

View reviewed changes

docs/linting/Troubleshooting.mdxShow resolvedHide resolved

JoshuaKGoldberg requested a review fromJosh-Cena

April 16, 2023 18:46

JoshuaKGoldberg commented

Apr 16, 2023

View reviewed changes

docs/linting/Troubleshooting.mdx

Copy link

MemberAuthor

JoshuaKGoldbergApr 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@Jutanium would love your input on this if you have time 😇

Copy link

nx-cloudbot commentedApr 16, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3de2d52. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

bradzacher added the documentationDocumentation ("docs") that needs adding/updating label

Apr 17, 2023

Josh-Cena reviewed

Apr 17, 2023

View reviewed changes

docs/linting/Troubleshooting.mdx OutdatedShow resolvedHide resolved

Josh-Cena reviewed

Apr 17, 2023

View reviewed changes

docs/linting/Troubleshooting.mdx OutdatedShow resolvedHide resolved

docs/linting/Typed_Linting.mdx OutdatedShow resolvedHide resolved

JoshuaKGoldbergand others added2 commits

April 18, 2023 10:08

Apply suggestions from code review

0e23a30

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>

Update docs/linting/Typed_Linting.mdx

87117c7

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>

Copy link

codecovbot commentedApr 18, 2023•
edited
Loading

Codecov Report

Merging#6919 (87117c7) intomain (1944d42) willdecrease coverage by0.01%.
The diff coverage isn/a.

❗ Current head87117c7 differs from pull request most recent head3de2d52. Consider uploading reports for the commit3de2d52 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##             main    #6919      +/-   ##==========================================- Coverage   87.37%   87.37%   -0.01%==========================================  Files         386      386                Lines       13195    13192       -3       Branches     3867     3867              ==========================================- Hits        11529    11526       -3  Misses       1300     1300                Partials      366      366