typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

fix(eslint-plugin): [no-unnecessary-condition] allow nullish coalescing for naked type parameter#6910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromdora1998:fix-no-unnecessary-condition

Apr 17, 2023

Merged

fix(eslint-plugin): [no-unnecessary-condition] allow nullish coalescing for naked type parameter#6910

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromdora1998:fix-no-unnecessary-condition

Apr 17, 2023

Conversation

Copy link

Contributor

dora1998 commentedApr 15, 2023

PR Checklist

Addresses an existing open issue:fixesBug: [no-unnecessary-condition] False positive for generic type #6902
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Allow nullish coalescing for a naked type parameter because it might be nullable.

fix(eslint-plugin): [no-unnecessary-condition] allow nullish coalesci…

64cb69e

…ng for naked type parameter

Copy link

Contributor

typescript-eslintbot commentedApr 15, 2023

Thanks for the PR,@dora1998!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 15, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`a1c766c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/643ce33c777a170007d0cb9f
😎 Deploy Preview	https://deploy-preview-6910--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

Copy link

nx-cloudbot commentedApr 15, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commita1c766c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedApr 15, 2023•
edited
Loading

Codecov Report

Merging#6910 (a1c766c) intomain (40f4eee) willincrease coverage by0.00%.
The diff coverage is100.00%.

Additional details and impacted files

@@           Coverage Diff           @@##             main    #6910   +/-   ##=======================================  Coverage   87.36%   87.37%           =======================================  Files         386      386             Lines       13189    13192    +3       Branches     3866     3867    +1     =======================================+ Hits        11523    11526    +3  Misses       1300     1300             Partials      366      366

Flag	Coverage Δ
unittest	`87.37% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts	`98.37% <100.00%> (ø)`

... and1 file with indirect coverage changes

armano2 previously approved these changes

Apr 15, 2023

View reviewed changes

JoshuaKGoldberg requested changes

Apr 16, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM for just the case of a type parameter, thanks! Just requesting a bit more test coverage please. ✨

packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts

		}
		`,
		`
		function test<T>(a: T) {

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Testing] The cases ofT extends 'a' (always truthy) andT extends 'a' | null (still needing??) seem to work, but aren't explicitly covered for?? cases. Could you add in a couple more unit tests along those lines please?