Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(website): validate rule options in editor#6907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
armano2 merged 7 commits intov6fromchore/playground-validate-rule-schema
Apr 16, 2023

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedApr 14, 2023
edited
Loading

PR Checklist

Overview

Enable rule schema validation in playground

rec-34925.mp4

config with errors
config without errors

{"rules": {"@typescript-eslint/naming-convention": ["error",      {"selector": ["enum"        ]      },      {"selector": ["enum"        ],"format":null      }    ],"@typescript-eslint/consistent-generic-constructors": ["error","type-d"    ],"@typescript-eslint/explicit-member-accessibility": ["error",      {"accessibility":""      }    ],"id-denylist": ["error",2    ],// rule schema with object in items"@typescript-eslint/padding-line-between-statements": ["error",      {"blankLine":"always"      }    ],// this should error on to big array"no-unused-labels": ["error",false    ],// rule schema with array in items"array-element-newline": ["error","a"    ],// rule schema that contains oneOf"logical-assignment-operators": ["error","always",      {"enforceForIfStatements":true      }    ],// rule schema that contains anyOf"eqeqeq": ["error","always"    ],// additional checks"@typescript-eslint/func-call-spacing": ["error"    ],"no-restricted-globals": ["error","test","bar",2],"@typescript-eslint/ban-ts-comment": ["warn","w"]  }}

ref:#6896#6899

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedApr 14, 2023
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3a5b13a
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/643c35d5f2b88d0009ee152b
😎 Deploy Previewhttps://deploy-preview-6907--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@nx-cloud
Copy link

nx-cloudbot commentedApr 14, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3a5b13a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.

@armano2armano2 marked this pull request as draftApril 14, 2023 13:44
@armano2armano2 marked this pull request as ready for reviewApril 14, 2023 15:55
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code seems great, except for the bug? Very into this!

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 no more:. Thanks!

@armano2armano2 merged commit5ee6180 intov6Apr 16, 2023
@armano2armano2 deleted the chore/playground-validate-rule-schema branchApril 16, 2023 18:05
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 24, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@armano2@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp