Thanks for the PR,@RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	189d04a
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/652ede0ff4a9620007242cdb
😎 Deploy Preview	https://deploy-preview-6870--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 91 (🔴 down 4 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@marekdedic

☁️ Nx Cloud Report

CI is running/has finished running commands for commit189d04a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

Sent with 💌 fromNxCloud.

Oh, great! I was going to write in#6866 that I'd like to port that logic toPackageSpecifier :D

BTW, there'll be a merge conflict with#6780, but no big deal, they're both tiny changes...

Adding a test for this would probably be quite convoluted, right?

@RebeccaStevens I'm hoping to get through the last bits of v6 work today since we're set to launch on Monday. I think that'll just entail mergingv6 into this PR's branch and adding a few unit tests - which I'm fine to do on my own, and plan on doing in a few hours. Please let me know if you already started and I can hold off 😄

Hmm, yeah, these unit tests are tough. I ran out of time tonight. Will try again tomorrow.

😕 I can't figure this out.9b49480 shows a unit test that I would think should populateprogram.sourceFileToPackageName, but it'sMap(0) {size: 0}. Either I've misunderstood how to use the combination oftypeRoots +sourceFileToPackageName in this unit test(more likely), or that currently-internal API isn't made for this use case(also plausible), or there's a bug withsourceFileToPackageName(less likely).

To repro:

1. Put a breakpoint onhttps://github.com/JoshuaKGoldberg/typescript-eslint/blob/9b4948056790f764b3864badc57823db82cc528e/packages/type-utils/src/TypeOrValueSpecifier.ts#L166
2. OpenTypeOrValueSpecifier.test.ts
3. Launch the VS Code debugger forRun currently open type-utils test (F5)
4. Observe thatprogram.sourceFileToPackageName is empty, even though earlier in the call stack (https://github.com/JoshuaKGoldberg/typescript-eslint/blob/959819186291a93e17e99e52973a68f3a352c2f5/packages/type-utils/tests/TypeOrValueSpecifier.test.ts#L146),type is correctly resolved toexport interface Foo

Yeah, I gave up on the test too. I came to the conclusion that internal test API thingy isn't setup to do these sort of tests. I didn't want to open that can of worms of editing that.

If I remember right, local tests I tried using a separate repo passed. I can't really turn those into unit test though.

This was unintentionally auto-closed when we merged thev6 branch 🙃 it'll berecreated reopened.