typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(type-utils): treat intrinsic types as if they are from lib and never match error types#6869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 4 commits intotypescript-eslint:v6fromRebeccaStevens:issue/6867

Jul 7, 2023

Merged

fix(type-utils): treat intrinsic types as if they are from lib and never match error types#6869

JoshuaKGoldberg merged 4 commits intotypescript-eslint:v6fromRebeccaStevens:issue/6867

Jul 7, 2023

Conversation

Copy link

Contributor

RebeccaStevens commentedApr 8, 2023•
edited by JoshuaKGoldberg
Loading

PR Checklist

Addresses an existing open issue:fixesBug: v6typeMatchesSpecifierLibSpecifier should return true for intrinsic types (string, number, boolean, etc) #6867
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Adds explicit logic for intrinsic types and error types.

Copy link

Contributor

typescript-eslintbot commentedApr 8, 2023

Thanks for the PR,@RebeccaStevens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedApr 8, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`e04ca7b`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64a78d16ccbf7b0008ee8313
😎 Deploy Preview	https://deploy-preview-6869--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

ContributorAuthor

RebeccaStevens commentedApr 8, 2023

@marekdedic

Copy link

nx-cloudbot commentedApr 8, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite04ca7b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

Copy link

Contributor

marekdedic commentedApr 8, 2023

Hmm, good catch that native types aren't covered... Treating them as being from a lib is a bit of a simplification, but I think it's OK.

Not a maintainer, but could you please add a test?

Copy link

codecovbot commentedApr 8, 2023•
edited
Loading

Codecov Report

Merging#6869 (86372df) intov6 (e6235bf) willdecrease coverage by0.25%.
The diff coverage is60.00%.

❗ Current head86372df differs from pull request most recent head0990cf6. Consider uploading reports for the commit0990cf6 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@##               v6    #6869      +/-   ##==========================================- Coverage   87.70%   87.46%   -0.25%==========================================  Files         372      374       +2       Lines       12813    12887      +74       Branches     3795     3812      +17     ==========================================+ Hits        11238    11271      +33- Misses       1199     1231      +32- Partials      376      385       +9

Flag	Coverage Δ
unittest	`87.46% <60.00%> (-0.25%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted Files	Coverage Δ
packages/type-utils/src/TypeOrValueSpecifier.ts	`83.87% <60.00%> (-6.46%)`	⬇️

... and40 files with indirect coverage changes

RebeccaStevens changed the title~~fix(type-utils): treat native types as if they are from lib~~fix(type-utils): treat intrinsic types as if they are from lib

Apr 8, 2023

bradzacher added the bugSomething isn't working label

Apr 10, 2023

RebeccaStevens force-pushed theissue/6867 branch fromc5fe22d to86372dfCompare

April 10, 2023 13:41

JoshuaKGoldberg requested changes

Apr 16, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yup seems reasonable so far, but I'll take a closer look once there's some test coverage. 👍

packages/type-utils/src/TypeOrValueSpecifier.tsShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Apr 16, 2023

RebeccaStevens force-pushed theissue/6867 branch 2 times, most recently from6815b8c tocae8223Compare

June 15, 2023 11:17

RebeccaStevens changed the title~~fix(type-utils): treat intrinsic types as if they are from lib~~fix(type-utils): treat intrinsic types as if they are from lib and never match error types

Jun 15, 2023

JoshuaKGoldberg reviewed

Jun 17, 2023

View reviewed changes

packages/type-utils/tests/TypeOrValueSpecifier.test.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg approved these changes

Jun 17, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thanks@RebeccaStevens! 🚀

JoshuaKGoldberg added this to the6.0.0 milestone

Jun 17, 2023

marekdedic suggested changes

Jun 17, 2023

View reviewed changes

Copy link

Contributor

marekdedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd like to see one more test for error types, otherwise LGTM, thanks!

packages/type-utils/src/TypeOrValueSpecifier.ts OutdatedShow resolvedHide resolved

Copy link

Member

JoshuaKGoldberg commentedJul 6, 2023

@RebeccaStevens is this still something you have time to look into soon? No worries if not, I can touch things up myself tomorrow / this weekend in preparation for v6 (currently scheduled for Monday!).