Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): [playground] inline visual editor instead of showing modal#6813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedApr 1, 2023•
edited
Loading

PR Checklist

Overview

  • correct issues with re-rendering and constant updating of visual editor
  • move visual editor to be displayed in place of text editor

ref#6656 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedApr 1, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf389193
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/642b4177253f5c00083fbe0a
😎 Deploy Previewhttps://deploy-preview-6813--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@armano2armano2 changed the titlechore(website): [playground] correct issues with re-renders of visual…chore(website): [playground] update visual editor re-render issuesApr 1, 2023
@nx-cloud
Copy link

nx-cloudbot commentedApr 1, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4ad4efc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.

@armano2armano2 marked this pull request as draftApril 1, 2023 13:06
@armano2armano2 changed the titlechore(website): [playground] update visual editor re-render issueschore(website): [playground] display visual editor in left panel instead of modalApr 1, 2023
@armano2armano2 changed the titlechore(website): [playground] display visual editor in left panel instead of modalchore(website): [playground] inline visual editor instead of showing modalApr 1, 2023
@armano2armano2 marked this pull request as ready for reviewApril 1, 2023 21:55
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

YES so hyped for this!! Love it!

@armano2armano2 merged commitefd6ca9 intov6Apr 3, 2023
@armano2armano2 deleted the fix/correct-issues-with-rerended-of-config-editor branchApril 3, 2023 21:22
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@armano2@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp