Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(website): [playground] use languageService for linting code#6806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
armano2 merged 12 commits intov6fromchore/playground-refactor-code-to-use-tsvfs
Apr 7, 2023

Conversation

armano2
Copy link
Collaborator

@armano2armano2 commentedMar 31, 2023
edited
Loading

PR Checklist

Overview

extracted from#6656

  • migrate custom program creation to languageService
  • correct issues with race conditions and double lint
  • use tsvfs in broader scope to create program, store and sync files content
  • create clear boundaries between editor, linter and parser

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMar 31, 2023
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf04f533
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/642d9ae943a5070008995f82
😎 Deploy Previewhttps://deploy-preview-6806--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

@armano2

This comment was marked as resolved.

@armano2armano2 marked this pull request as draftMarch 31, 2023 16:34
@nx-cloud
Copy link

nx-cloudbot commentedMar 31, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf04f533. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.

@armano2armano2 changed the titlechore(website): [playground] use tsvfs as for linting codechore(website): [playground] use tsvfs for linting codeMar 31, 2023
@bradzacher
Copy link
Member

I wonder if we should make it easier to integrate the vfs into our parser by adding a new API?

@armano2armano2 marked this pull request as ready for reviewApril 1, 2023 14:32
@armano2
Copy link
CollaboratorAuthor

armano2 commentedApr 1, 2023
edited
Loading

I wonder if we should make it easier to integrate the vfs into our parser by adding a new API?

that could work, but in our case we actually have to get ast from parser witch currently is done during parsing

https://github.com/typescript-eslint/typescript-eslint/pull/6806/files#diff-d05a371466c38384729239098e16a3a40108ecf9bff740757faca055e308f6edR27-R28

https://github.com/typescript-eslint/typescript-eslint/pull/6806/files#diff-ce4bea04942123f7add4111ea7ee55b67313bcea7257fb247423c82d0fcd59b3R81-R86

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok I'll admit, this is a lot of TS API -intense stuff that I'm not super familiar with. I'm digging into it now and it all seems good... but I'm in a bit of a rush and can't do a full"read and learn all the things and their context" review 😞. So consider this a medium-level-informed LGTM. Assuming I'm not missing any non-obvious gotchas, the code looks great! Awesome! 🔥

@armano2armano2 changed the titlechore(website): [playground] use tsvfs for linting codechore(website): [playground] use languageService for linting codeApr 7, 2023
@armano2armano2 merged commita35a2bb intov6Apr 7, 2023
@armano2armano2 deleted the chore/playground-refactor-code-to-use-tsvfs branchApril 7, 2023 09:40
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 15, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@armano2@bradzacher@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp