typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

chore(website): [playground] add support for extends in eslint config#6796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

armano2 merged 4 commits intov6fromchore/playground-add-support-for-extends

Apr 2, 2023

Merged

chore(website): [playground] add support for extends in eslint config#6796

armano2 merged 4 commits intov6fromchore/playground-add-support-for-extends

Apr 2, 2023

Conversation

Copy link

Collaborator

armano2 commentedMar 30, 2023•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesWebsite: [Playground] config should support available presets from ts-eslint and eslint #5171
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

extracted from#6656

"extends" field is now read while into account while parsing code

Tooltip in rules now includes url to rule doc

Warning
overrides do not work
seehttps://github.com/typescript-eslint/typescript-eslint/blob/v6/packages/eslint-plugin/src/configs/eslint-recommended.ts
https://github.com/eslint/eslint/blob/4c46fb3d861ca12e86f868af19778ce988238da7/lib/linter/linter.js#L1463-L1466

chore(website): [playground] add support for extends in eslint config

4c9bea6

Copy link

Contributor

typescript-eslintbot commentedMar 30, 2023

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMar 30, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`4ec8d97`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6429fe062cc26e000860b1f7
😎 Deploy Preview	https://deploy-preview-6796--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

armano2 added the website: playground label

Mar 30, 2023

armano2 mentioned this pull request

Mar 30, 2023

chore(website): [playground] add support for extends, ts types and more#6656

Closed

3 tasks

Copy link

nx-cloudbot commentedMar 30, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4ec8d97. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 30 targets