typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

chore(website): [playground] allow to choose file extensions#6785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

armano2 merged 13 commits intov6fromchore/playground-file-type-selection

Apr 2, 2023

Merged

chore(website): [playground] allow to choose file extensions#6785

armano2 merged 13 commits intov6fromchore/playground-file-type-selection

Apr 2, 2023

Conversation

Copy link

Collaborator

armano2 commentedMar 28, 2023•
edited
Loading

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

extracted from#6656

This change replacesjsx checkbox with dropdown of supported file extensions

ref#5449

Copy link

Contributor

typescript-eslintbot commentedMar 28, 2023

Thanks for the PR,@armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMar 28, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`c5d359b`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6429d2b86f5eb200089bc8e3
😎 Deploy Preview	https://deploy-preview-6785--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site settings.

armano2 mentioned this pull request

Mar 28, 2023

chore(website): [playground] add support for extends, ts types and more#6656

Closed

3 tasks

Copy link

nx-cloudbot commentedMar 28, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitc5d359b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.

armano2 added the website: playground label

Mar 29, 2023

chore(website): [playground] allow to choose file extensions

a77fcf0

armano2 force-pushed thechore/playground-file-type-selection branch from0a22f1f toa77fcf0Compare

March 29, 2023 15:30

chore(website): use config fileTypes in readFileType

75611fb

bradzacher reviewed

Mar 30, 2023

View reviewed changes

packages/website/src/components/editor/LoadedEditor.tsx OutdatedShow resolvedHide resolved

packages/website/src/components/config.ts Outdated

Comment on lines 10 to 20

		export const fileTypes: ConfigFileType[] = [
		'ts',
		'tsx',
		'js',
		'jsx',
		'd.ts',
		'cjs',
		'mjs',
		'cts',
		'mts',
		];

Copy link

Member

bradzacherMar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

could this beObject.values(ts.Extension) instead?

Copy link

CollaboratorAuthor

armano2Mar 30, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

when this variable is initialized playground and typescript is not loaded yet and we can't wait for playground to load because this is needed to define file name that is used by playground